Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLN: Rename private variables to inclusive #47655

Merged
merged 4 commits into from
Jul 10, 2022

Conversation

phofl
Copy link
Member

@phofl phofl commented Jul 9, 2022

No description provided.

phofl added 4 commits July 7, 2022 19:28
…interval

# Conflicts:
#	pandas/_libs/interval.pyi
#	pandas/core/arrays/arrow/_arrow_utils.py
#	pandas/core/arrays/interval.py
@phofl phofl added Interval Interval data type Clean labels Jul 9, 2022
@mroeschke mroeschke added this to the 1.5 milestone Jul 10, 2022
@mroeschke mroeschke merged commit 102b3ca into pandas-dev:main Jul 10, 2022
@mroeschke
Copy link
Member

Thanks @phofl

yehoshuadimarsky pushed a commit to yehoshuadimarsky/pandas that referenced this pull request Jul 13, 2022
* CLN: Rename private variables from closed to inclusive

* Rename variables in dtypes too

* Fix tests
@phofl phofl deleted the cln_variable_names_interval branch July 18, 2022 00:24
mroeschke added a commit to mroeschke/pandas that referenced this pull request Aug 17, 2022
mroeschke added a commit that referenced this pull request Aug 18, 2022
…48116)

* Revert "Cln tests interval wrt inclusive (#47775)"

This reverts commit 2d6e0b2.

* Revert "CLN: Rename private variables to inclusive  (#47655)"

This reverts commit 102b3ca.

* Revert "TYP: Improve typing interval inclusive (#47646)"

This reverts commit 5506476.

* Revert "DEPR: Deprecate set_closed and add set_incluive (#47636)"

This reverts commit bd4ff39.

* Revert "DEPR: Remove deprecation from private class IntervalTree (#47637)"

This reverts commit f6658ef.

* Revert "Revert inclusive default change of IntervalDtype (#47367)"

This reverts commit d9dd128.

* Revert "ENH: consistency of input args for boundaries - Interval (#46522)"

This reverts commit 7e23a37.

* Revert "ENH: consistency of input args for boundaries -  pd.interval_range (#46355)"

This reverts commit 073b353.

* Fix ArrowIntervalType manually

* Remove unused import

* Fix doctest and leftover usage

* Fix remaining tests

* Fix wording in doctoring

Co-authored-by: Patrick Hoefler <61934744+phofl@users.noreply.github.com>
noatamir pushed a commit to noatamir/pandas that referenced this pull request Nov 9, 2022
…andas-dev#48116)

* Revert "Cln tests interval wrt inclusive (pandas-dev#47775)"

This reverts commit 2d6e0b2.

* Revert "CLN: Rename private variables to inclusive  (pandas-dev#47655)"

This reverts commit 102b3ca.

* Revert "TYP: Improve typing interval inclusive (pandas-dev#47646)"

This reverts commit 5506476.

* Revert "DEPR: Deprecate set_closed and add set_incluive (pandas-dev#47636)"

This reverts commit bd4ff39.

* Revert "DEPR: Remove deprecation from private class IntervalTree (pandas-dev#47637)"

This reverts commit f6658ef.

* Revert "Revert inclusive default change of IntervalDtype (pandas-dev#47367)"

This reverts commit d9dd128.

* Revert "ENH: consistency of input args for boundaries - Interval (pandas-dev#46522)"

This reverts commit 7e23a37.

* Revert "ENH: consistency of input args for boundaries -  pd.interval_range (pandas-dev#46355)"

This reverts commit 073b353.

* Fix ArrowIntervalType manually

* Remove unused import

* Fix doctest and leftover usage

* Fix remaining tests

* Fix wording in doctoring

Co-authored-by: Patrick Hoefler <61934744+phofl@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Clean Interval Interval data type
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants