[CLN] call __finalize__ in quantile #47183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mroeschke
approved these changes
May 31, 2022
|
Thanks @theOehrly (failure was unrelated) |
38 tasks
yehoshuadimarsky
pushed a commit
to yehoshuadimarsky/pandas
that referenced
this pull request
Jul 13, 2022
* remove unreachable code in DataFrame.quantile * add test for increased coverage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In reference to #28283, this PR intends to ensure that
__finalize__is always called before returning the result ofDataFrame.quantile.This was already the case though, because
__finalize__is already called explicitly wherever necessary. Furthermore, my previous PR #46101 fixed the remaining problem with metadata propagation inquantileas that was caused by.iloc.There remained one return statement with no call to finalize. This code is unreachable though and now removed. The check
if is_list_like(q):is guaranteed to be true because a few lines upq = Index(...)andIndexis list-like.Additionally, I have added one more test to increase the coverage of the finalize tests in quantile.
(In case I am wrong and
Indexis not guaranteed to always be list-like, I'll add this code back and add the missing finalize call instead.)