Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: DatetimeIndex.resolution with nanosecond reso #46903

Merged
merged 12 commits into from
May 19, 2022

Conversation

jbrockmendel
Copy link
Member

  • closes #xxxx (Replace xxxx with the Github issue number)
  • Tests added and passed if fixing a bug or adding a new feature
  • All code checks passed.
  • Added an entry in the latest doc/source/whatsnew/vX.X.X.rst file if fixing a bug or adding a new feature.

@@ -23,9 +23,21 @@ def test_asof_nanosecond_index_access(self):

first_value = ser.asof(ser.index[0])

# GH#46903 previously incorrectly was "day"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you put this in a dedicated method (the deprecation check)

@jreback jreback added this to the 1.5 milestone May 4, 2022
@jreback jreback added Indexing Related to indexing on series/frames, not to indexes themselves Timezones Timezone data dtype Deprecate Functionality to remove in pandas labels May 4, 2022
Copy link
Member

@mroeschke mroeschke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if @jreback's comment was completely addressed but LGTM

@jbrockmendel
Copy link
Member Author

Rebased + green

@jreback jreback merged commit 4f92db3 into pandas-dev:main May 19, 2022
@jbrockmendel jbrockmendel deleted the bug-get_resolution branch May 19, 2022 15:12
yehoshuadimarsky pushed a commit to yehoshuadimarsky/pandas that referenced this pull request Jul 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Deprecate Functionality to remove in pandas Indexing Related to indexing on series/frames, not to indexes themselves Timezones Timezone data dtype
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants