Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC: add examples to groupby.first #46766

Merged
merged 1 commit into from
Apr 26, 2022

Conversation

Moisan
Copy link
Contributor

@Moisan Moisan commented Apr 13, 2022

  • closes #xxxx (Replace xxxx with the Github issue number)
  • Tests added and passed if fixing a bug or adding a new feature
  • All code checks passed.
  • Added an entry in the latest doc/source/whatsnew/vX.X.X.rst file if fixing a bug or adding a new feature.

Add a few more examples to groupby.first. I also removed the mention of numeric_only = None since the code doesn't check for None any case, nor does the type allow for it.

@pep8speaks
Copy link

pep8speaks commented Apr 13, 2022

Hello @Moisan! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2022-04-24 14:36:17 UTC

@Moisan Moisan force-pushed the groupby_first_doc_nan branch 2 times, most recently from 2810d09 to 327fe4b Compare April 13, 2022 15:30
@mroeschke mroeschke added the Docs label Apr 16, 2022
@jreback
Copy link
Contributor

jreback commented Apr 17, 2022

doesn't this fix the same as #46792 ? though this fixes for groupby i think that is fixed as well.

@Moisan
Copy link
Contributor Author

Moisan commented Apr 17, 2022

#46792 covers unused arguments in Resampler.first however GroupBy.first doc doesn't include unused arguments so I don't think that PR is related.

@mroeschke mroeschke added this to the 1.5 milestone Apr 24, 2022
@mroeschke
Copy link
Member

@Moisan could you merge in the main branch one more time? After that LGTM

@jreback jreback merged commit 1213a17 into pandas-dev:main Apr 26, 2022
@jreback
Copy link
Contributor

jreback commented Apr 26, 2022

thanks @Moisan

@Moisan Moisan deleted the groupby_first_doc_nan branch April 26, 2022 13:47
yehoshuadimarsky pushed a commit to yehoshuadimarsky/pandas that referenced this pull request Jul 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants