Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEPR: Categorical.replace #44929

Merged
merged 2 commits into from
Dec 16, 2021
Merged

Conversation

jbrockmendel
Copy link
Member

  • closes #xxxx
  • tests added / passed
  • Ensure all linting tests pass, see here for how to run them
  • whatsnew entry

We're going to have to move that logic from the Block to EA, and we don't want it to be part of the public API, so it will need to be _replace. Deprecating the Categorical method now to facilitate that change.

Also de-privatize Block._replace_list.

@jreback jreback added Categorical Categorical Data Type Deprecate Functionality to remove in pandas labels Dec 16, 2021
@jreback jreback added this to the 1.4 milestone Dec 16, 2021
@jreback jreback merged commit 01268aa into pandas-dev:master Dec 16, 2021
@jbrockmendel jbrockmendel deleted the enh-ea-replace branch December 16, 2021 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Categorical Categorical Data Type Deprecate Functionality to remove in pandas
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants