Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DEPR: rolling/expanding/ewm.validate #43665

Merged
merged 2 commits into from
Sep 20, 2021
Merged

DEPR: rolling/expanding/ewm.validate #43665

merged 2 commits into from
Sep 20, 2021

Conversation

mroeschke
Copy link
Member

  • tests added / passed
  • Ensure all linting tests pass, see here for how to run them
  • whatsnew entry

An method with validation logic that should be in __init__ ideally and should not be called by users.

@mroeschke mroeschke added Deprecate Functionality to remove in pandas Window rolling, ewma, expanding labels Sep 19, 2021
@jreback jreback added this to the 1.4 milestone Sep 20, 2021
@jreback jreback mentioned this pull request Sep 20, 2021
Closed
@jreback jreback merged commit 9a4b0a0 into pandas-dev:master Sep 20, 2021
@jreback
Copy link
Contributor

jreback commented Sep 20, 2021

thanks @mroeschke

@mroeschke mroeschke deleted the depr/validate branch September 20, 2021 16:59
@mroeschke mroeschke mentioned this pull request Sep 29, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Deprecate Functionality to remove in pandas Window rolling, ewma, expanding
Projects
None yet
Milestone
1.4
Development

Successfully merging this pull request may close these issues.
2 participants
@mroeschke @jreback