Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

REF: de-duplicate symmetric_difference, _union #41833

Merged
merged 6 commits into from
Jun 9, 2021
Merged

REF: de-duplicate symmetric_difference, _union #41833

merged 6 commits into from
Jun 9, 2021

Conversation

jbrockmendel
Copy link
Member

Also fixes buglet in CategoricalIndex.equals(MultiIndex)

@gfyoung gfyoung added Refactor Internal refactoring of code Indexing Related to indexing on series/frames, not to indexes themselves Index Related to the Index class or subclasses labels Jun 7, 2021
@jreback
Copy link
Contributor

jreback commented Jun 8, 2021

can you rebase

@jreback
Copy link
Contributor

jreback commented Jun 8, 2021

once more rebase

@jreback jreback added this to the 1.3 milestone Jun 9, 2021
@jreback
Copy link
Contributor

jreback commented Jun 9, 2021

yeah seeing failures on master

@jbrockmendel
Copy link
Member Author

rebased + green

@jreback jreback merged commit bf72b70 into pandas-dev:master Jun 9, 2021
@jreback
Copy link
Contributor

jreback commented Jun 9, 2021

wow nice

@jbrockmendel jbrockmendel deleted the ref-setops-2 branch June 9, 2021 15:02
@jorisvandenbossche
Copy link
Member

jorisvandenbossche commented Jun 10, 2021 •
edited
Loading

This seems to have caused several performance regressions, see https://pandas.pydata.org/speed/pandas/#regressions?sort=1&dir=desc (the ones for commit "bf72b70b")

@jorisvandenbossche jorisvandenbossche mentioned this pull request Jun 25, 2021
Closed
@jorisvandenbossche
Copy link
Member

Opened #42239 to track this regression

simonjayhawkins added a commit that referenced this pull request Jun 30, 2021
@jbrockmendel @simonjayhawkins
PERF/REGR: symmetric_difference revert most of #41833 (#42318)
be2efa9 
* PERF/REGR: symmetric_difference revert most of 41833

* mypy fixup

Co-authored-by: Simon Hawkins <simonjayhawkins@gmail.com>
simonjayhawkins pushed a commit to simonjayhawkins/pandas that referenced this pull request Jun 30, 2021
@jbrockmendel @simonjayhawkins
Backport PR pandas-dev#42318: PERF/REGR: symmetric_difference revert …
77f3cf4 
…most of pandas-dev#41833
simonjayhawkins added a commit that referenced this pull request Jun 30, 2021
@simonjayhawkins @jbrockmendel
Backport PR #42318: PERF/REGR: symmetric_difference revert most of #4…
061642a 
…1833 (#42324)

* Backport PR #42318: PERF/REGR: symmetric_difference revert most of #41833

* remove if self._is_multi block

* remove MultiIndex symmetric_difference

Co-authored-by: jbrockmendel <jbrockmendel@gmail.com>
JulianWgs pushed a commit to JulianWgs/pandas that referenced this pull request Jul 3, 2021
@jbrockmendel @JulianWgs
REF: de-duplicate symmetric_difference, _union (pandas-dev#41833)
c089f7e
JulianWgs pushed a commit to JulianWgs/pandas that referenced this pull request Jul 3, 2021
@jbrockmendel @simonjayhawkins @JulianWgs
PERF/REGR: symmetric_difference revert most of pandas-dev#41833 (pand…
0a9b608 
…as-dev#42318)

* PERF/REGR: symmetric_difference revert most of 41833

* mypy fixup

Co-authored-by: Simon Hawkins <simonjayhawkins@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Index Related to the Index class or subclasses Indexing Related to indexing on series/frames, not to indexes themselves Refactor Internal refactoring of code
Projects
None yet
Milestone
1.3
Development

Successfully merging this pull request may close these issues.
4 participants
@jbrockmendel @jreback @jorisvandenbossche @gfyoung