Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate passing args as positional DataFrame/Series.ffill #41508

Merged

Conversation

MarcoGorelli
Copy link
Member

@simonjayhawkins simonjayhawkins added the Deprecate Functionality to remove in pandas label May 17, 2021
@jorisvandenbossche jorisvandenbossche changed the title deprecate nonkeywordargs in ffill Deprecate passing args as positional DataFrame/Series.ffill May 17, 2021
@MarcoGorelli MarcoGorelli marked this pull request as draft May 18, 2021 08:14
@MarcoGorelli MarcoGorelli marked this pull request as ready for review May 18, 2021 20:54
Comment on lines -6390 to -6402
@overload
def ffill(
self: FrameOrSeries,
axis: None | Axis = ...,
inplace: Literal[False] = ...,
limit: None | int = ...,
downcast=...,
) -> FrameOrSeries:
Copy link
Member Author

@MarcoGorelli MarcoGorelli May 19, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will put the overloads back in once the FutureWarning's in, then we won't need as many

@simonjayhawkins simonjayhawkins added this to the 1.3 milestone May 24, 2021
@jreback
Copy link
Contributor

jreback commented May 26, 2021

can you merge master

@jreback jreback merged commit eb7d46d into pandas-dev:master May 27, 2021
@MarcoGorelli MarcoGorelli deleted the deprecate-nonkeyword-args-ffill branch May 27, 2021 08:17
JulianWgs pushed a commit to JulianWgs/pandas that referenced this pull request Jul 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Deprecate Functionality to remove in pandas
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants