Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLN: Move stuff in tests.indexes.test_numeric.py to more logical locations #41254

Merged
merged 3 commits into from
May 4, 2021

Conversation

topper-123
Copy link
Contributor

@topper-123 topper-123 commented May 1, 2021

This does four things to better organize the numeric index's tests:

  1. Moves test method test_index_groupby from tests.indexes.test_numeric.py::TestNumericIndex to tests.indexes.common.py::Base and makes it use a fixture. This means this tests will be used for all index types. Also deletes TestNumericIndex, as its empty now.
  2. Moves the Numeric class from test_numeric.py to common.py and renames it NumericBase.
  3. Moves the tests.indexes.numeric.py::TestArithmetic::test_arithmetic_explicit_conversions tests to the new common.py::NumericBase and delete test_numeric.py::TestArithmetic class, as it's now empty.
  4. Moves the file tests.indexes.test_numeric.py to tests.indexes.numeric.test_numeric.py.

@pandas-dev pandas-dev deleted a comment from pep8speaks May 1, 2021
@topper-123 topper-123 changed the title CLN: Move stuff in tests.indexes to more logical locations CLN: Move stuff in tests.indexes.test_numeric.py to more logical locations May 1, 2021
@simonjayhawkins simonjayhawkins added Clean Index Related to the Index class or subclasses Testing pandas testing functions or related to the test suite labels May 2, 2021
@jreback jreback added this to the 1.3 milestone May 2, 2021
@jreback
Copy link
Contributor

jreback commented May 2, 2021

looks fine, can you rebase.

@jbrockmendel ok here?

@jbrockmendel
Copy link
Member

LGTM; needs rebase

@topper-123
Copy link
Contributor Author

Ok, I’ve rebased.

@jreback jreback merged commit a740748 into pandas-dev:master May 4, 2021
@jreback
Copy link
Contributor

jreback commented May 4, 2021

thanks @topper-123

@topper-123 topper-123 deleted the cln_tests branch May 5, 2021 16:33
JulianWgs pushed a commit to JulianWgs/pandas that referenced this pull request Jul 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Clean Index Related to the Index class or subclasses Testing pandas testing functions or related to the test suite
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants