Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Styler builtins: highlight_between #39821

Merged
merged 69 commits into from
Apr 13, 2021
Merged

Conversation

attack68
Copy link
Contributor

@attack68 attack68 commented Feb 15, 2021

  • tests added / passed

  • Ensure all linting tests pass, see here for how to run them

  • whatsnew entry

  • update docs for existing highlight functions for consistency

  • add a new props argument to existing highlight functions.

Will add tests if approved:
Could wrap both methods into one as well, but probably easier api if two?

Screen Shot 2021-02-15 at 17 54 23

Screen Shot 2021-02-15 at 18 20 34

@attack68 attack68 marked this pull request as draft February 15, 2021 17:04
@lithomas1 lithomas1 added the Styler conditional formatting using DataFrame.style label Feb 16, 2021
@jreback
Copy link
Contributor

jreback commented Feb 17, 2021

I like this, esp the smile, have to have it.

@jreback
Copy link
Contributor

jreback commented Feb 17, 2021

cc @TomAugspurger

@attack68 attack68 added this to the 1.3 milestone Feb 18, 2021
@attack68 attack68 marked this pull request as ready for review February 19, 2021 11:22
@attack68 attack68 changed the title [WIP] ENH: Styler builtins: highlight_range and highlight_quantile ENH: Styler builtins: highlight_range and highlight_quantile Feb 19, 2021
Copy link
Contributor

@jnothman jnothman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise LGTM

pandas/io/formats/style.py Outdated Show resolved Hide resolved
pandas/io/formats/style.py Outdated Show resolved Hide resolved
@attack68 attack68 requested a review from jreback April 11, 2021 15:15
@jreback
Copy link
Contributor

jreback commented Apr 12, 2021

can you merge master

@attack68
Copy link
Contributor Author

@jreback ping on merge and green

@jreback jreback merged commit c7ffc84 into pandas-dev:master Apr 13, 2021
@jreback
Copy link
Contributor

jreback commented Apr 13, 2021

thanks @attack68 very nice.

can you make sure that the notebook is up to date after last few things merged.

@attack68
Copy link
Contributor Author

thanks @attack68 very nice.

can you make sure that the notebook is up to date after last few things merged.

yes I will do that in coming week.

@attack68 attack68 deleted the range_builtin branch April 13, 2021 14:32
JulianWgs pushed a commit to JulianWgs/pandas that referenced this pull request Jul 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement Styler conditional formatting using DataFrame.style
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants