BUG: incorrect casting in DataFrame.append #39454
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jreback
requested changes
Feb 1, 2021
| upcast_classes = _get_upcast_classes(join_units, dtypes) | ||
|
|
||
| if is_extension_array_dtype(dtype_alt): |
There was a problem hiding this comment.
can we just drop the upcast_classes stuff and just do an if/elseif here on dtype_alt? (as you have done with extension / object)
There was a problem hiding this comment.
i think we're going to get there eventually, but there are a handful of tests that break if we do that right away. i think the behavior in those tests can be considered buggy (xref #39122), but want to address them in bite-size pieces
jreback
approved these changes
Feb 1, 2021
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm pretty sure we're going to end up with just using find_common_type instead of re-implementing similar stuff in internals.concat.