Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DEPR: astype dt64<->dt64tz #39258

Merged
merged 8 commits into from
Jan 21, 2021
Merged

DEPR: astype dt64<->dt64tz #39258

merged 8 commits into from
Jan 21, 2021

Conversation

jbrockmendel
Copy link
Member

@jreback jreback added Deprecate Functionality to remove in pandas Datetime Datetime data dtype labels Jan 20, 2021
jreback
jreback requested changes Jan 20, 2021
View reviewed changes
doc/source/user_guide/timeseries.rst Show resolved Hide resolved
pandas/core/dtypes/cast.py Outdated Show resolved Hide resolved
pandas/core/dtypes/cast.py Outdated Show resolved Hide resolved
pandas/core/dtypes/cast.py Outdated
@@ -942,6 +942,32 @@ def coerce_indexer_dtype(indexer, categories):
return ensure_int64(indexer)


def _find_level() -> int:
"""
Find the appropriate stacklevel with which to issue a warning for astype.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i would move this elsewhere, maybe to pandas.util._validation (or similar).

maybe just pass the names in as needed e.g. L958 (or hard-code ok too)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe util._exceptions?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated + green

@jreback jreback added this to the 1.3 milestone Jan 20, 2021
@jreback jreback mentioned this pull request Jan 20, 2021
Closed
jreback
jreback requested changes Jan 20, 2021
View reviewed changes
Copy link
Contributor

@jreback jreback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested with DTI, Series, DTA? (i think so, just confirming). do we allow this with Timestamp? (obviously deprecate if we do)

@jbrockmendel
Copy link
Member Author

tested with DTI, Series, DTA? (i think so, just confirming).

Yes

do we allow this with Timestamp? (obviously deprecate if we do)

No, there is no Timestamp.astype

@jreback jreback merged commit f958cf5 into pandas-dev:master Jan 21, 2021
@jreback
Copy link
Contributor

jreback commented Jan 21, 2021

great

@jbrockmendel jbrockmendel deleted the depr-astype-dt64tz branch January 21, 2021 15:23
@rhshadrach rhshadrach mentioned this pull request May 8, 2021
Merged
1 task
@mroeschke mroeschke mentioned this pull request Jun 11, 2021
Closed
3 tasks
@anthonyozerov anthonyozerov mentioned this pull request Jun 1, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jreback jreback jreback approved these changes

Assignees
No one assigned
Labels
Datetime Datetime data dtype Deprecate Functionality to remove in pandas
Projects
None yet
Milestone
1.3
Development

Successfully merging this pull request may close these issues.

BUG: dt64 <-> dt64tz roundup
2 participants
@jbrockmendel @jreback