DOC: chat-ops #38754
DOC: chat-ops #38754
Conversation
|
@githubactions pre-commit |
There was a problem hiding this comment.
Thanks for the PR! I assume meeseeksdev can only be used by someone with write permissions; remarks should be made to that effect. I'm also wondering if there should be some language around backporting to the effect of "you shouldn't be using this unless you really know otherwise". Thoughts here @simonjayhawkins?
|
|
||
| on that pull request. This will trigger a workflow which will autofix formatting errors. | ||
|
|
||
| Backporting (optional) |
There was a problem hiding this comment.
this should only be in the maintainers section (i think we have one?)
There was a problem hiding this comment.
Yes, doc/source/development/maintaining.rst - @1nF0rmed could you move this over there please?
There was a problem hiding this comment.
Does that include the backporting section?
There was a problem hiding this comment.
yes, the whole part about @meeseeksdev backport should be in the maintainers section
| you make a pull request. If there is a scenario where any of these checks fail then you | ||
| can comment:: | ||
|
|
||
| @githubactions pre-commit |
There was a problem hiding this comment.
this should be
| @githubactions pre-commit | |
| @github-actions pre-commit |
, I missed out the - in the issue
|
I'll make these changes and commit ASAP |
🤣 thanks, but there's no hurry |
| Autofixing formatting errors | ||
| ---------------------------- | ||
|
|
||
| We use several styling checks (e.g. ``black``, ``flake8``, ``isort``) which are run after | ||
| you make a pull request. If there is a scenario where any of these checks fail then you | ||
| can comment:: | ||
|
|
||
| @github-actions pre-commit | ||
|
|
||
| on that pull request. This will trigger a workflow which will autofix formatting errors. |
There was a problem hiding this comment.
Sorry for being unclear - this part can go in contributing.rst, it's the backporting section that should go in maintaining.rst
|
thanks @1nF0rmed if any more comments @rhshadrach @MarcoGorelli |
|
thanks @1nF0rmed |
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diff@githubactions pre-commit@meeseeksdev backport