Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

REF: consolidate NDFrame._iset_item, _set_item with DataFrame methods #38389

Merged
merged 1 commit into from
Dec 10, 2020
Merged

REF: consolidate NDFrame._iset_item, _set_item with DataFrame methods #38389

merged 1 commit into from
Dec 10, 2020

Conversation

jbrockmendel
Copy link
Member

  • closes #xxxx
  • tests added / passed
  • passes black pandas
  • passes git diff upstream/master -u -- "*.py" | flake8 --diff
  • whatsnew entry

@jreback jreback added Indexing Related to indexing on series/frames, not to indexes themselves Internals Related to non-user accessible pandas implementation labels Dec 10, 2020
@jreback jreback added this to the 1.3 milestone Dec 10, 2020
@jreback jreback merged commit d932752 into pandas-dev:master Dec 10, 2020
@jreback
Copy link
Contributor

jreback commented Dec 10, 2020

nice, yeah we shouldn't have any internal function calls like that outside of internals

@jbrockmendel jbrockmendel deleted the ref-setitem branch December 10, 2020 00:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Indexing Related to indexing on series/frames, not to indexes themselves Internals Related to non-user accessible pandas implementation
Projects
None yet
Milestone
1.3
Development

Successfully merging this pull request may close these issues.
2 participants
@jbrockmendel @jreback