Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CLN: fix C408 #38138 #38385

Merged
merged 1 commit into from
Dec 9, 2020
Merged

CLN: fix C408 #38138 #38385

merged 1 commit into from
Dec 9, 2020

Conversation

fangchenli
Copy link
Member

@fangchenli fangchenli commented Dec 9, 2020 •
edited
Loading

@simonjayhawkins simonjayhawkins added Clean Code Style Code style, linting, code_checks labels Dec 9, 2020
@simonjayhawkins simonjayhawkins added this to the 1.3 milestone Dec 9, 2020
jbrockmendel
jbrockmendel approved these changes Dec 9, 2020
View reviewed changes
Copy link
Member

@jbrockmendel jbrockmendel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@simonjayhawkins simonjayhawkins merged commit 6b5357a into pandas-dev:master Dec 9, 2020
@simonjayhawkins
Copy link
Member

Thanks @fangchenli

@fangchenli fangchenli deleted the remove-C408 branch November 18, 2022 02:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbrockmendel jbrockmendel jbrockmendel approved these changes

Assignees
No one assigned
Labels
Clean Code Style Code style, linting, code_checks
Projects
None yet
Milestone
1.3
Development

Successfully merging this pull request may close these issues.

CLN: C408 Unnecessary dict call - rewrite as a literal
3 participants
@fangchenli @simonjayhawkins @jbrockmendel