CLN: Implement multiindex handling for get_op_result_name #38323
Conversation
|
Can we do this by overriding get_reconciled_name_object and not get_op_result_name? id like to avoid the small-but-frequent additional overhead there |
|
pls merge master |
…n_get_op_result_name � Conflicts: � pandas/core/indexes/multi.py � pandas/tests/indexes/multi/test_setops.py
|
Done and Done |
pandas/core/ops/common.py
Outdated
| @@ -122,3 +122,30 @@ def _maybe_match_name(a, b): | |||
| elif b_has: | |||
| return b.name | |||
| return None | |||
|
|
|||
|
|
|||
| def maybe_match_names_multiindex(a, b): | |||
There was a problem hiding this comment.
can you type a, b and the return
There was a problem hiding this comment.
Don't need to type this after moving?
| @@ -93,7 +93,7 @@ def _maybe_match_name(a, b): | |||
| """ | |||
There was a problem hiding this comment.
would rename this to maybe_match_names
pandas/core/ops/common.py
Outdated
| """ | ||
| Try to find common names to attach to the result of an operation between | ||
| a and b. Return a consensus list of names if they match at least partly | ||
| or None if they have completely different names. |
There was a problem hiding this comment.
this could just be in padnas/core/indexes/multi.py i think would be fine
|
LGTM ex @jreback comments |
|
also pls merge master |
…n_get_op_result_name � Conflicts: � pandas/core/indexes/multi.py
|
looks good. is this user visible in any way? e.g you mention: |
|
No, we did use rename previously which avoided this. But now we are consistent between the intersection methods |
|
thanks @phofl |
…#38323) * CLN: Implement multiindex handling for get_op_result_name * Change import order * Override method * Move import * Remove import * Fix merge issue * Move methods
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diff@jbrockmendel
This would solve the inconsistency in
get_op_result_namefor MultiIndexes, but adds a bit more complexity here.I think this would allow us to remove the now duplicated code in
intersection