BUG: DataFrame reductions inconsistent with Series counterparts #37827
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jreback
added
Nuisance Columns
|
#28948 is an incorrect ref (top of PR) |
jreback
requested changes
Nov 14, 2020
| A 1.0 | ||
| dtype: float64 | ||
|
|
||
| *New behavior*: |
There was a problem hiding this comment.
needs to be an ipython block & remove the prompts
| A True | ||
| dtype: bool | ||
|
|
||
| *New behavior*: |
There was a problem hiding this comment.
make an ipython block & remove the prompts
| @@ -513,8 +516,14 @@ def make_a_block(nv, ref_loc): | |||
| v = new_values[i] | |||
|
|
|||
| # need a new block | |||
| if m.any(): | |||
| nv = f(m, v, i) | |||
| if m.any() or m.size == 0: | |||
There was a problem hiding this comment.
can you add a comment here on what is going on
| # Double-check the Series behavior is to raise | ||
| with pytest.raises(TypeError, match="does not implement reduction"): | ||
| getattr(ser, method)() | ||
| with pytest.raises(TypeError, match="does not implement reduction"): |
| # Double-check the Series behavior | ||
| with pytest.raises(TypeError, match="is not ordered for operation"): | ||
| getattr(ser, method)() | ||
| with pytest.raises(TypeError, match="is not ordered for operation"): |
| @@ -284,6 +284,58 @@ of columns could result in a larger :class:`Series` result. See (:issue:`37799`) | |||
| In [6]: df[["B", "C"]].all(bool_only=True) | |||
|
|
|||
|
|
|||
| Other :class:`DataFrame` reductions with ``numeric_only=None`` will also avoid | |||
| this pathological behavior (:issue:`37827`): | |||
There was a problem hiding this comment.
can you make sure to list all the issues you are closing the OP (3?)
jreback
approved these changes
Nov 14, 2020
jreback
requested changes
Nov 14, 2020
doc/source/whatsnew/v1.2.0.rst
Outdated
|
|
||
| *New behavior*: | ||
|
|
||
| .. code-block:: ipython |
There was a problem hiding this comment.
needs to be an ipython block to render
There was a problem hiding this comment.
dangit, i thought i had copied from the previous reduction PR, was so proud of myself
doc/source/whatsnew/v1.2.0.rst
Outdated
|
|
||
| *New behavior*: | ||
|
|
||
| .. code-block:: ipython |
jreback
added
Categorical
jreback
approved these changes
Nov 14, 2020
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diff