TST/REF: finish collecting sample tests #37470
Conversation
| @pytest.mark.parametrize("klass", [Series, DataFrame]) | ||
| def test_sample_random_state(self, func_str, arg, klass): | ||
| # GH#32503 | ||
| obj = DataFrame({"col1": range(10, 20), "col2": range(20, 30)}) | ||
| if klass is Series: | ||
| obj = obj["col1"] |
There was a problem hiding this comment.
Would it be better to have obj explicitly parametrized without performing checks inside the test method?
@pytest.mark.parametrize("obj", [Series(...), DataFrame({...})])
There was a problem hiding this comment.
i find this cleaner, also smaller memory footprint because constructing outside gets done at test collection time instead of test runtime
There was a problem hiding this comment.
OK, understood. Thank you for clarification on the footprint!
| @pytest.mark.parametrize("klass", [Series, DataFrame]) | ||
| def test_sample_upsampling_without_replacement(self, klass): | ||
| # GH#27451 | ||
|
|
||
| obj = DataFrame({"A": list("abc")}) | ||
| if klass is Series: | ||
| obj = obj["A"] |
| with pytest.raises(ValueError): | ||
| ser = Series(range(10)) | ||
| ser.sample(n=1, axis=1) |
There was a problem hiding this comment.
Test is related to Series, contradicts the comment on top of this class.
There was a problem hiding this comment.
yah, there's further work to be done splitting these up
|
thanks, just a note before you go all in on moving the generic tests. we ought to consider just splitting these back to series/dataframe. yes now they are essentiallly in 2 places, but we already have a ton like this. the original reason for generic was to also test panel, well that's over so something to consider. |
Parametrizes a few tests from the frame.methods.test_sample file, splits up giant tests from the generic file.