Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Troubleshoot PY38 windows build #37455

Merged
merged 8 commits into from
Oct 31, 2020
Merged

Conversation

jbrockmendel
Copy link
Member

Some of the error messages look like a OOM, so this is just trying cutting down the number of tests collected/run by ~40%

@jbrockmendel
Copy link
Member Author

@simonjayhawkins thoughts on a better way to approach this. the win38 build has passed twice in a row here, suggesting this might be on to something

@AlexKirko
Copy link
Member

AlexKirko commented Oct 30, 2020

In case this helps with troubleshooting: on my local Windows 10 machine on a py38 env, the test suite fails with a stack overflow exception. However, when I run tests folder-by-folder, the folder it had failed on passes. Looks like some kind of memory leak accumulating stuff on stack to me.

@jbrockmendel
Copy link
Member Author

The windows py38 build has succeeded here 4ish times in a row, making me think the issue is just "the test suite is too big for that particular build"

Thoughts on more elegant ways to solve this cc @pandas-dev/pandas-core ?

@jreback
Copy link
Contributor

jreback commented Oct 30, 2020

so we are skipping high memory tests? ok sounds fine to me to merge (is there any pure debugging code here?)

@jbrockmendel
Copy link
Member Author

so we are skipping high memory tests? ok sounds fine to me to merge (is there any pure debugging code here?)

ATM this PR isnt just skipping high-memory tests, its also very hackily running a subset of tests

@jreback
Copy link
Contributor

jreback commented Oct 30, 2020

can u try skipping some files instead (until it reliably passes)

py.test --ignore=somedir

would be a more less fragile i think

@jbrockmendel
Copy link
Member Author

can u try skipping some files instead (until it reliably passes)

@AlexKirko can you give this a shot locally before I try it on the CI?

@jreback jreback added Window rolling, ewma, expanding CI Continuous Integration labels Oct 31, 2020
@jreback jreback added this to the 1.2 milestone Oct 31, 2020
@jreback
Copy link
Contributor

jreback commented Oct 31, 2020

this looks reasonable, merging will create an issue to see if can troubleshoot at some point.

@jreback jreback merged commit 5a66348 into pandas-dev:master Oct 31, 2020
@jbrockmendel jbrockmendel deleted the ci-win38 branch October 31, 2020 15:20
kesmit13 pushed a commit to kesmit13/pandas that referenced this pull request Nov 2, 2020
ukarroum pushed a commit to ukarroum/pandas that referenced this pull request Nov 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Continuous Integration Window rolling, ewma, expanding
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants