Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TYP: DatetimeIndex, TimedeltaIndex #37365

Merged
merged 6 commits into from
Oct 29, 2020
Merged

Conversation

jbrockmendel
Copy link
Member

Better alternative to parts of #37224

@jbrockmendel jbrockmendel mentioned this pull request Oct 23, 2020
5 tasks
@@ -411,6 +417,21 @@ def union_many(self, others):
return this.rename(res_name)
return this

def _maybe_utc_convert(self, other):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you type this at all?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated+greenish

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all the way green

@jreback jreback added Datetime Datetime data dtype Timezones Timezone data dtype Typing type annotations, mypy/pyright type checking labels Oct 26, 2020
@jreback jreback added this to the 1.2 milestone Oct 26, 2020
@jreback jreback merged commit e1624e5 into pandas-dev:master Oct 29, 2020
@jbrockmendel jbrockmendel deleted the typ-gb-2 branch October 29, 2020 02:00
kesmit13 pushed a commit to kesmit13/pandas that referenced this pull request Nov 2, 2020
ukarroum pushed a commit to ukarroum/pandas that referenced this pull request Nov 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Datetime Datetime data dtype Timezones Timezone data dtype Typing type annotations, mypy/pyright type checking
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants