Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUG: stabilize sort_values algorithms for Series and time-like Indices #37310

Merged
merged 79 commits into from
Oct 31, 2020
Merged

BUG: stabilize sort_values algorithms for Series and time-like Indices #37310

merged 79 commits into from
Oct 31, 2020

Commits on Oct 20, 2020

  1. BUG: stabilize sorting in Series.sort_values

    @AlexKirko
    AlexKirko committed Oct 20, 2020
    Configuration menu
    Copy the full SHA
    151c425 View commit details
    Browse the repository at this point in the history

  2. DOC: add comment to nargsort call in Series.sort_values

    @AlexKirko
    AlexKirko committed Oct 20, 2020
    Configuration menu
    Copy the full SHA
    7332255 View commit details
    Browse the repository at this point in the history

Commits on Oct 21, 2020

  1. use nargsort with indices: Period, DateTime, TimeDelta

    @AlexKirko
    AlexKirko committed Oct 21, 2020
    Configuration menu
    Copy the full SHA
    546b9fa View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into stable-dupe-sort

    @AlexKirko
    AlexKirko committed Oct 21, 2020
    Configuration menu
    Copy the full SHA
    12eb535 View commit details
    Browse the repository at this point in the history

  3. mv NaNs to the end of dupe lists in value_counts

    @AlexKirko
    AlexKirko committed Oct 21, 2020
    Configuration menu
    Copy the full SHA
    9b51d42 View commit details
    Browse the repository at this point in the history

  4. CLN: remove extra comment indents

    @AlexKirko
    AlexKirko committed Oct 21, 2020
    Configuration menu
    Copy the full SHA
    7805d1e View commit details
    Browse the repository at this point in the history

  5. attempt to mimic previous count_values behavior by reversing before sort

    @AlexKirko
    AlexKirko committed Oct 21, 2020
    Configuration menu
    Copy the full SHA
    2b75f78 View commit details
    Browse the repository at this point in the history

  6. CLN: clean-up unnecessary import

    @AlexKirko
    AlexKirko committed Oct 21, 2020
    Configuration menu
    Copy the full SHA
    2844a97 View commit details
    Browse the repository at this point in the history

  7. Revert "attempt to mimic previous count_values behavior by reversing … 

    …before sort"

This reverts commit 2b75f78.
    @AlexKirko
    AlexKirko committed Oct 21, 2020
    Configuration menu
    Copy the full SHA
    965a547 View commit details
    Browse the repository at this point in the history

  8. TST: alter tests in test_algos

    @AlexKirko
    AlexKirko committed Oct 21, 2020
    Configuration menu
    Copy the full SHA
    29d47ee View commit details
    Browse the repository at this point in the history

  9. TST: alter value_counts dupe order in boolean/test_function

    @AlexKirko
    AlexKirko committed Oct 21, 2020
    Configuration menu
    Copy the full SHA
    151196d View commit details
    Browse the repository at this point in the history

  10. mv NaT to end of dupe sort order, alter test_value_counts 

    NaT is expected to be last in th elist of duplicate value counts
guarantee that by finding it and moving to the end of the array
(consider giving it up: the code ends up cluttered)
Also alter test_value_counts to make sure that expectations
match new sort_values stability
    @AlexKirko
    AlexKirko committed Oct 21, 2020
    Configuration menu
    Copy the full SHA
    d71bfc8 View commit details
    Browse the repository at this point in the history

  11. REFACT: use tuple unpacking for element swap

    @AlexKirko
    AlexKirko committed Oct 21, 2020
    Configuration menu
    Copy the full SHA
    aff28ac View commit details
    Browse the repository at this point in the history

Commits on Oct 22, 2020

  1. DOC: clarify comments in algorithms/value_counts

    @AlexKirko
    AlexKirko committed Oct 22, 2020
    Configuration menu
    Copy the full SHA
    0b8aae9 View commit details
    Browse the repository at this point in the history

  2. stop forcing NaN-like to be at the end of dupe order

    @AlexKirko
    AlexKirko committed Oct 22, 2020
    Configuration menu
    Copy the full SHA
    e7cebc4 View commit details
    Browse the repository at this point in the history

  3. TST: NaN-like is now first among duplicates in count_values

    @AlexKirko
    AlexKirko committed Oct 22, 2020
    Configuration menu
    Copy the full SHA
    06931e0 View commit details
    Browse the repository at this point in the history

  4. CLN: remove unnecessary is_bool import in series.py

    @AlexKirko
    AlexKirko committed Oct 22, 2020
    Configuration menu
    Copy the full SHA
    0b24c3e View commit details
    Browse the repository at this point in the history

  5. TST: value_counts NaN dupe order change in test_string.py

    @AlexKirko
    AlexKirko committed Oct 22, 2020
    Configuration menu
    Copy the full SHA
    1b98bff View commit details
    Browse the repository at this point in the history

  6. TST: value_counts NaN dupe order in test_value_counts.py

    @AlexKirko
    AlexKirko committed Oct 22, 2020
    Configuration menu
    Copy the full SHA
    4076f0c View commit details
    Browse the repository at this point in the history

  7. CLN: rm unnecessary assignment from test_value_counts

    @AlexKirko
    AlexKirko committed Oct 22, 2020
    Configuration menu
    Copy the full SHA
    08aadd3 View commit details
    Browse the repository at this point in the history

  8. TST: expect stable sort in extension/base/methods.py

    @AlexKirko
    AlexKirko committed Oct 22, 2020
    Configuration menu
    Copy the full SHA
    6f904e6 View commit details
    Browse the repository at this point in the history

  9. BUG: support objs that raise when cast to their class

    @AlexKirko
    AlexKirko committed Oct 22, 2020
    Configuration menu
    Copy the full SHA
    5c7eea9 View commit details
    Browse the repository at this point in the history

  10. TST: fix stable sort expectation in test_sort_values in methods.py

    @AlexKirko
    AlexKirko committed Oct 22, 2020
    Configuration menu
    Copy the full SHA
    75aad12 View commit details
    Browse the repository at this point in the history

  11. TST: change top expect for dupe counts in frame/test_describe

    @AlexKirko
    AlexKirko committed Oct 22, 2020
    Configuration menu
    Copy the full SHA
    e503dca View commit details
    Browse the repository at this point in the history

  12. BUG: clean up crutches in Series.nlargest 

    Now that sort_values is stable, we don't need to reverse
order in algorithms.SelectNSeries.compute, which is
the backend of Series.nlargest
    @AlexKirko
    AlexKirko committed Oct 22, 2020
    Configuration menu
    Copy the full SHA
    759de34 View commit details
    Browse the repository at this point in the history

  13. TST: change dupe order expect in frame/methods/test_value_counts

    @AlexKirko
    AlexKirko committed Oct 22, 2020
    Configuration menu
    Copy the full SHA
    12741f2 View commit details
    Browse the repository at this point in the history

  14. TST: change dupe order expectation in indexes/datetimes/test_ops

    @AlexKirko
    AlexKirko committed Oct 22, 2020
    Configuration menu
    Copy the full SHA
    d433952 View commit details
    Browse the repository at this point in the history

  15. TST: specify na-position in indexes/datetimes/test_ops.py

    @AlexKirko
    AlexKirko committed Oct 22, 2020
    Configuration menu
    Copy the full SHA
    dc906df View commit details
    Browse the repository at this point in the history

  16. TST: specify na-position in indexes/period/test_ops.py

    @AlexKirko
    AlexKirko committed Oct 22, 2020
    Configuration menu
    Copy the full SHA
    dbf295e View commit details
    Browse the repository at this point in the history

  17. TST: remove xfail from test_order_stability_compat

    @AlexKirko
    AlexKirko committed Oct 22, 2020
    Configuration menu
    Copy the full SHA
    cbe528e View commit details
    Browse the repository at this point in the history

  18. TST: change dupe order expect for indexes/timedeltas/test_ops

    @AlexKirko
    AlexKirko committed Oct 22, 2020
    Configuration menu
    Copy the full SHA
    6658b73 View commit details
    Browse the repository at this point in the history

  19. BUG: reintroduce ascending param error-catching to sort_values

    @AlexKirko
    AlexKirko committed Oct 22, 2020
    Configuration menu
    Copy the full SHA
    076fa7a View commit details
    Browse the repository at this point in the history

  20. BUG: reintroduce proper key func support to Series.sort_values

    @AlexKirko
    AlexKirko committed Oct 22, 2020
    Configuration menu
    Copy the full SHA
    cdf63a3 View commit details
    Browse the repository at this point in the history

  21. BUG: fix bug in key func support

    @AlexKirko
    AlexKirko committed Oct 22, 2020
    Configuration menu
    Copy the full SHA
    dd30ec9 View commit details
    Browse the repository at this point in the history

  22. TST: alter dupe order expect in series/methods/test_value_counts

    @AlexKirko
    AlexKirko committed Oct 22, 2020
    Configuration menu
    Copy the full SHA
    5cac5c7 View commit details
    Browse the repository at this point in the history

Commits on Oct 23, 2020

  1. CLN: remove unused variable in Series.sort_values

    @AlexKirko
    AlexKirko committed Oct 23, 2020
    Configuration menu
    Copy the full SHA
    7a68a45 View commit details
    Browse the repository at this point in the history

  2. BUG: set values in key func support in Series.sort_values

    @AlexKirko
    AlexKirko committed Oct 23, 2020
    Configuration menu
    Copy the full SHA
    4c72dbf View commit details
    Browse the repository at this point in the history

  3. DOC: add whatsnew

    @AlexKirko
    AlexKirko committed Oct 23, 2020
    Configuration menu
    Copy the full SHA
    3599591 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'master' into stable-dupe-sort

    @AlexKirko
    AlexKirko committed Oct 23, 2020
    Configuration menu
    Copy the full SHA
    3ee9b8b View commit details
    Browse the repository at this point in the history

  5. BUG: add SparseArray sorting with key func support

    @AlexKirko
    AlexKirko committed Oct 23, 2020
    Configuration menu
    Copy the full SHA
    d63293c View commit details
    Browse the repository at this point in the history

  6. TST: remove datetime-like xfails when testing indices with missing

    @AlexKirko
    AlexKirko committed Oct 23, 2020
    Configuration menu
    Copy the full SHA
    a5c8f65 View commit details
    Browse the repository at this point in the history

  7. TST: fix expect dupe sort order in doctests

    @AlexKirko
    AlexKirko committed Oct 23, 2020
    Configuration menu
    Copy the full SHA
    fc90ea9 View commit details
    Browse the repository at this point in the history

  8. BUG: fix bug in Series reconstruction after sorting

    @AlexKirko
    AlexKirko committed Oct 23, 2020
    Configuration menu
    Copy the full SHA
    408abe0 View commit details
    Browse the repository at this point in the history

  9. TST: fix expect dupe sort order in more doctests

    @AlexKirko
    AlexKirko committed Oct 23, 2020
    Configuration menu
    Copy the full SHA
    5f53cfc View commit details
    Browse the repository at this point in the history

  10. BUG: support key func changing ndarray dtype

    @AlexKirko
    AlexKirko committed Oct 23, 2020
    Configuration menu
    Copy the full SHA
    4370f27 View commit details
    Browse the repository at this point in the history

  11. REFACT: reuse keyed

    @AlexKirko
    AlexKirko committed Oct 23, 2020
    Configuration menu
    Copy the full SHA
    6099344 View commit details
    Browse the repository at this point in the history

  12. TST: remove datetime-like xfails from invalid_na_position

    @AlexKirko
    AlexKirko committed Oct 23, 2020
    Configuration menu
    Copy the full SHA
    bfa2b28 View commit details
    Browse the repository at this point in the history

  13. TST: fix expect dupe sort order in more doctests in base.py

    @AlexKirko
    AlexKirko committed Oct 23, 2020
    Configuration menu
    Copy the full SHA
    bc004ec View commit details
    Browse the repository at this point in the history

  14. CLN: remove unnecessary imports in indexes/test_common.py

    @AlexKirko
    AlexKirko committed Oct 23, 2020
    Configuration menu
    Copy the full SHA
    cd7111e View commit details
    Browse the repository at this point in the history

  15. CLN: run black

    @AlexKirko
    AlexKirko committed Oct 23, 2020
    Configuration menu
    Copy the full SHA
    5fbbf7d View commit details
    Browse the repository at this point in the history

  16. Merge branch 'master' into stable-dupe-sort

    @AlexKirko
    AlexKirko committed Oct 23, 2020
    Configuration menu
    Copy the full SHA
    95b9f25 View commit details
    Browse the repository at this point in the history

Commits on Oct 27, 2020

  1. incorporate both conflicting whatsnew

    @AlexKirko
    AlexKirko committed Oct 27, 2020
    Configuration menu
    Copy the full SHA
    1dc9b89 View commit details
    Browse the repository at this point in the history

  2. try removing if in ensure_key_mapped to find tests

    @AlexKirko
    AlexKirko committed Oct 27, 2020
    Configuration menu
    Copy the full SHA
    2946e46 View commit details
    Browse the repository at this point in the history

  3. BUG: just apply key func to the whole Series in sort_values

    @AlexKirko
    AlexKirko committed Oct 27, 2020
    Configuration menu
    Copy the full SHA
    488596c View commit details
    Browse the repository at this point in the history

  4. remove legacy try/except with default to quicksort

    @AlexKirko
    AlexKirko committed Oct 27, 2020
    Configuration menu
    Copy the full SHA
    c8cd8cd View commit details
    Browse the repository at this point in the history

  5. DOC: expand whatsnew

    @AlexKirko
    AlexKirko committed Oct 27, 2020
    Configuration menu
    Copy the full SHA
    ab71697 View commit details
    Browse the repository at this point in the history

  6. CLN: remove unnecessary SparseArray import

    @AlexKirko
    AlexKirko committed Oct 27, 2020
    Configuration menu
    Copy the full SHA
    05f60d5 View commit details
    Browse the repository at this point in the history

  7. restart tests

    @AlexKirko
    AlexKirko committed Oct 27, 2020
    Configuration menu
    Copy the full SHA
    8669e89 View commit details
    Browse the repository at this point in the history

  8. restart tests again (windows_np18 misbehaving)

    @AlexKirko
    AlexKirko committed Oct 27, 2020
    Configuration menu
    Copy the full SHA
    00b454c View commit details
    Browse the repository at this point in the history

  9. restart tests again

    @AlexKirko
    AlexKirko committed Oct 27, 2020
    Configuration menu
    Copy the full SHA
    5d5f3d0 View commit details
    Browse the repository at this point in the history

  10. DOC: add information on sorting NaTs to whatsnew

    @AlexKirko
    AlexKirko committed Oct 27, 2020
    Configuration menu
    Copy the full SHA
    3d7f47c View commit details
    Browse the repository at this point in the history

  11. DOC: phrasing change in whatsnew

    @AlexKirko
    AlexKirko committed Oct 27, 2020
    Configuration menu
    Copy the full SHA
    351a003 View commit details
    Browse the repository at this point in the history

Commits on Oct 28, 2020

  1. Merge branch 'master' into stable-dupe-sort

    @AlexKirko
    AlexKirko committed Oct 28, 2020
    Configuration menu
    Copy the full SHA
    8de6ac9 View commit details
    Browse the repository at this point in the history

  2. DOC: clarify whatsnew

    @AlexKirko
    AlexKirko committed Oct 28, 2020
    Configuration menu
    Copy the full SHA
    18bb141 View commit details
    Browse the repository at this point in the history

  3. CLN: clean up unnecessary newlines in sorting.py 

    Also bring back the cast comment
    @AlexKirko
    AlexKirko committed Oct 28, 2020
    Configuration menu
    Copy the full SHA
    9b97302 View commit details
    Browse the repository at this point in the history

  4. DOC: clarify whatsnew some more

    @AlexKirko
    AlexKirko committed Oct 28, 2020
    Configuration menu
    Copy the full SHA
    3a88ebe View commit details
    Browse the repository at this point in the history

  5. bring back na_position validation in Series.sort_values

    @AlexKirko
    AlexKirko committed Oct 28, 2020
    Configuration menu
    Copy the full SHA
    d41789e View commit details
    Browse the repository at this point in the history

  6. DOC: add to whatsnew

    @AlexKirko
    AlexKirko committed Oct 28, 2020
    Configuration menu
    Copy the full SHA
    812f312 View commit details
    Browse the repository at this point in the history

  7. DOC: clarify NaTs sorting changes in whatsnew

    @AlexKirko
    AlexKirko committed Oct 28, 2020
    Configuration menu
    Copy the full SHA
    e28ce4d View commit details
    Browse the repository at this point in the history

  8. DOC: add other api changes to whatsnew; move doc there

    @AlexKirko
    AlexKirko committed Oct 28, 2020
    Configuration menu
    Copy the full SHA
    0719633 View commit details
    Browse the repository at this point in the history

  9. CLN: run black

    @AlexKirko
    AlexKirko committed Oct 28, 2020
    Configuration menu
    Copy the full SHA
    61ac60d View commit details
    Browse the repository at this point in the history

Commits on Oct 29, 2020

  1. Merge branch 'master' into stable-dupe-sort

    @AlexKirko
    AlexKirko committed Oct 29, 2020
    Configuration menu
    Copy the full SHA
    d495064 View commit details
    Browse the repository at this point in the history

  2. DOC: attempt fixing malformed link in whatsnew

    @AlexKirko
    AlexKirko committed Oct 29, 2020
    Configuration menu
    Copy the full SHA
    36932cd View commit details
    Browse the repository at this point in the history

  3. Revert "DOC: attempt fixing malformed link in whatsnew" 

    This reverts commit 36932cd.
    @AlexKirko
    AlexKirko committed Oct 29, 2020
    Configuration menu
    Copy the full SHA
    2156c64 View commit details
    Browse the repository at this point in the history

  4. DOC: fix broken link in whatsnew

    @AlexKirko
    AlexKirko committed Oct 29, 2020
    Configuration menu
    Copy the full SHA
    e6f5741 View commit details
    Browse the repository at this point in the history

  5. restart tests

    @AlexKirko
    AlexKirko committed Oct 29, 2020
    Configuration menu
    Copy the full SHA
    c823043 View commit details
    Browse the repository at this point in the history

Commits on Oct 30, 2020

  1. Merge branch 'master' into stable-dupe-sort

    @AlexKirko
    AlexKirko committed Oct 30, 2020
    Configuration menu
    Copy the full SHA
    cd66748 View commit details
    Browse the repository at this point in the history

Commits on Oct 31, 2020

  1. REFACT: clean up key if/else in Series.sort_values

    @AlexKirko
    AlexKirko committed Oct 31, 2020
    Configuration menu
    Copy the full SHA
    37a6439 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into stable-dupe-sort

    @AlexKirko
    AlexKirko committed Oct 31, 2020
    Configuration menu
    Copy the full SHA
    d09da99 View commit details
    Browse the repository at this point in the history