BUG: Index sortlevel ascending add type checking #32334 #36767
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dr-Irv
requested changes
Oct 1, 2020
I have added the v1.2 whatsnew entry , please take a look |
Dr-Irv
requested changes
Oct 1, 2020
doc/source/whatsnew/v1.2.0.rst
Outdated
| @@ -352,7 +352,7 @@ Indexing | |||
| - Bug in :meth:`PeriodIndex.get_loc` incorrectly raising ``ValueError`` on non-datelike strings instead of ``KeyError``, causing similar errors in :meth:`Series.__geitem__`, :meth:`Series.__contains__`, and :meth:`Series.loc.__getitem__` (:issue:`34240`) | |||
| - Bug in :meth:`Index.sort_values` where, when empty values were passed, the method would break by trying to compare missing values instead of pushing them to the end of the sort order. (:issue:`35584`) | |||
| - Bug in :meth:`Index.get_indexer` and :meth:`Index.get_indexer_non_unique` where int64 arrays are returned instead of intp. (:issue:`36359`) | |||
| - | |||
| - Bug in :meth:`Index.sortlevel` where, add the check of ascending parameter in the sortlevel method, only allow bool value and single bool value list. (:issue:`32334`) | |||
There was a problem hiding this comment.
Better to say
Bug in :meth:`DataFrame.sort_index` where parameter ascending passed as a list on a single level index gives wrong result. (:issue:`32334`)
There was a problem hiding this comment.
whatsnew has been adjusted, please take a look
Dr-Irv
approved these changes
Oct 1, 2020
|
thanks @BEANNAN |
jreback
reviewed
Oct 1, 2020
| @@ -2222,6 +2222,31 @@ def test_contains_method_removed(self, index): | |||
| with pytest.raises(AttributeError, match=msg): | |||
| index.contains(1) | |||
|
|
|||
| def test_sortlevel(self): | |||
| index = pd.Index([5, 4, 3, 2, 1]) | |||
There was a problem hiding this comment.
we generally add the issue number here as a comment
| with pytest.raises(Exception, match="ascending must be a bool value"): | ||
| index.sortlevel(ascending=["True"]) | ||
|
|
||
| expected = pd.Index([1, 2, 3, 4, 5]) |
There was a problem hiding this comment.
this should be 2 tests, one for the exceptions, one for the working cases (which could be parameterized)
| @@ -1515,6 +1515,20 @@ def sortlevel(self, level=None, ascending=True, sort_remaining=None): | |||
| ------- | |||
| Index | |||
| """ | |||
| if not isinstance(ascending, (list, bool)): | |||
There was a problem hiding this comment.
these should be checked at a much lower level, where they are used; the reason these are fairly generic things not specific to Index in this case
kesmit13
pushed a commit
to kesmit13/pandas
that referenced
this pull request
Nov 2, 2020
…ndas-dev#36767) * BUG: Index sortlevel ascending add type checking pandas-dev#32334 * DOC: add v1.2 whatsnew entry pandas-dev#32334 * BUG: adjust judgment conditions, len(ascending) > 1 => len(ascending) != 1 * DOC: adjustment whatsnew Co-authored-by: beanan <fanjianan916@hotmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diffAdd the check of ascending parameter in the sortlevel method, only allow bool value and single bool value list
cc @Dr-Irv