-
-
Notifications
You must be signed in to change notification settings - Fork 17.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CLN: Don't use astype_nansafe after to_numpy #34110
Conversation
Personally, I think those rather should convert to StringArray |
Interesting idea, that does seem better |
not at all, |
@dsaxton can you merge master |
That's true. So in pandas, we generally see But so, I personally think we can already interpret |
I disagree, we always have |
Which is also not what this PR is doing ... |
I'm not 100% sure about the change in the tests, but it seems to align with numpy: