Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding test for assert_equal_index with empty iterables #29211

Merged

Conversation

VijayantSoni
Copy link
Contributor

@VijayantSoni VijayantSoni commented Oct 24, 2019

@gfyoung gfyoung added the Testing pandas testing functions or related to the test suite label Oct 24, 2019


def test_index_equal_empty_iterable():
a = MultiIndex(levels=[[], []], codes=[[], []], names=['a', 'b'])
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reference issue as a comment right above.

@mroeschke
Copy link
Member

You will need to run black pandas

Copy link
Member

@mroeschke mroeschke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you move this test to pandas/tests/indexes/multi/test_constructor.py

@mroeschke mroeschke merged commit 9c0f7c8 into pandas-dev:master Oct 29, 2019
@mroeschke
Copy link
Member

Thanks @VijayantSoni

@VijayantSoni
Copy link
Contributor Author

Thank you guys @mroeschke @gfyoung

Reksbril pushed a commit to Reksbril/pandas that referenced this pull request Nov 18, 2019
…9211)

* Adding test for assert_equal_index with empty iterables

* Adding issue # in comment

* formatted file using black

* Move test to indexes/multi/test_constructor.py
proost pushed a commit to proost/pandas that referenced this pull request Dec 19, 2019
…9211)

* Adding test for assert_equal_index with empty iterables

* Adding issue # in comment

* formatted file using black

* Move test to indexes/multi/test_constructor.py
proost pushed a commit to proost/pandas that referenced this pull request Dec 19, 2019
…9211)

* Adding test for assert_equal_index with empty iterables

* Adding issue # in comment

* formatted file using black

* Move test to indexes/multi/test_constructor.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Testing pandas testing functions or related to the test suite
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: factorize_from_iterables applies type to empty iterables
3 participants