Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC: Fixed PR06 docstring errors in pandas.interval_range & pandas.util.hash_array #28760

Merged
merged 4 commits into from
Oct 7, 2019

Conversation

samyak-jn
Copy link
Contributor

@samyak-jn samyak-jn commented Oct 2, 2019

DOC: Fixed PR06 docstring errors in pandas.interval_range

DOC: Fixed PR06 docstring errors in pandas.interval_range
DOC: Fixed PR06 docstring errors in pandas.util.hash_array
@samyak-jn samyak-jn changed the title DOC: Fixed PR06 docstring errors in pandas.interval_range DOC: Fixed PR06 docstring errors in pandas.interval_range & pandas.util.hash_array Oct 2, 2019
@gfyoung gfyoung added the Docs label Oct 2, 2019
Copy link
Member

@datapythonista datapythonista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the fixes @samyak-jn, but if you contribute further, please do it to the docstrings reported by the script, the ones fixed here are private and we don't care as much

pandas/core/util/hashing.py Outdated Show resolved Hide resolved
pandas/core/util/hashing.py Outdated Show resolved Hide resolved
pandas/core/util/hashing.py Outdated Show resolved Hide resolved
@jreback jreback added this to the 1.0 milestone Oct 7, 2019
@jreback
Copy link
Contributor

jreback commented Oct 7, 2019

lgtm. @datapythonista

@datapythonista datapythonista merged commit a1dba2c into pandas-dev:master Oct 7, 2019
@datapythonista
Copy link
Member

Thanks for the fixes @samyak-jn

proost pushed a commit to proost/pandas that referenced this pull request Dec 19, 2019
proost pushed a commit to proost/pandas that referenced this pull request Dec 19, 2019
bongolegend pushed a commit to bongolegend/pandas that referenced this pull request Jan 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants