Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: Fix groupby quantile array #28113

Merged
merged 2 commits into from
Aug 26, 2019

Conversation

TomAugspurger
Copy link
Contributor

xref #28085 (comment)

This is a regression in 0.25.2. It was partially fixed in #28085, but there was an issue with the first fix.

@TomAugspurger TomAugspurger added Groupby Regression Functionality that used to work in a prior pandas version labels Aug 23, 2019
@TomAugspurger TomAugspurger added this to the 0.25.2 milestone Aug 23, 2019
@jbrockmendel
Copy link
Member

LGTM

@dragoljub
Copy link

@TomAugspurger thanks for the quick fix and adding the test! 👍

@TomAugspurger
Copy link
Contributor Author

@WillAyd care to glance at this?

Note that this whole section is a bit hacky, but can be removed entirely once #10710 is fixed.

@WillAyd
Copy link
Member

WillAyd commented Aug 26, 2019

lgtm - can you add a whatsnew?

@TomAugspurger
Copy link
Contributor Author

Whoops, added.

Copy link
Member

@WillAyd WillAyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

merge on green

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Groupby Regression Functionality that used to work in a prior pandas version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants