Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport PR #25338 on branch 0.24.x (Interval dtype fix) #25380

Merged

Conversation

meeseeksmachine
Copy link
Contributor

Backport PR #25338: Interval dtype fix

@lumberbot-app lumberbot-app bot added this to the 0.24.2 milestone Feb 20, 2019
@pep8speaks
Copy link

Hello @meeseeksmachine! Thanks for submitting the PR.

Line 941:17: E117 over-indented

@codecov
Copy link

codecov bot commented Feb 20, 2019

Codecov Report

Merging #25380 into 0.24.x will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           0.24.x   #25380      +/-   ##
==========================================
+ Coverage   92.39%   92.39%   +<.01%     
==========================================
  Files         166      166              
  Lines       52409    52412       +3     
==========================================
+ Hits        48424    48428       +4     
+ Misses       3985     3984       -1
Flag Coverage Δ
#multiple 90.82% <100%> (ø) ⬆️
#single 42.88% <75%> (ø) ⬆️
Impacted Files Coverage Δ
pandas/core/dtypes/dtypes.py 96.12% <100%> (+0.51%) ⬆️
pandas/util/testing.py 88.04% <0%> (-0.1%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f0cf03d...5e3179a. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Feb 20, 2019

Codecov Report

Merging #25380 into 0.24.x will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           0.24.x   #25380      +/-   ##
==========================================
+ Coverage   92.39%   92.39%   +<.01%     
==========================================
  Files         166      166              
  Lines       52409    52412       +3     
==========================================
+ Hits        48424    48428       +4     
+ Misses       3985     3984       -1
Flag Coverage Δ
#multiple 90.82% <100%> (ø) ⬆️
#single 42.88% <75%> (ø) ⬆️
Impacted Files Coverage Δ
pandas/core/dtypes/dtypes.py 96.12% <100%> (+0.51%) ⬆️
pandas/util/testing.py 88.04% <0%> (-0.1%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f0cf03d...5e3179a. Read the comment docs.

@gfyoung gfyoung added Dtype Conversions Unexpected or buggy dtype conversions Interval Interval data type labels Feb 20, 2019
@gfyoung gfyoung merged commit 48e9955 into pandas-dev:0.24.x Feb 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Dtype Conversions Unexpected or buggy dtype conversions Interval Interval data type
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants