Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport PR #25304 on branch 0.24.x (BUG: Fix passing of numeric_only argument for categorical reduce) #25344

Merged

Conversation

meeseeksmachine
Copy link
Contributor

Backport PR #25304: BUG: Fix passing of numeric_only argument for categorical reduce

@lumberbot-app lumberbot-app bot added this to the 0.24.2 milestone Feb 16, 2019
@jreback jreback added the Categorical Categorical Data Type label Feb 16, 2019
@codecov
Copy link

codecov bot commented Feb 16, 2019

Codecov Report

Merging #25344 into 0.24.x will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           0.24.x   #25344      +/-   ##
==========================================
+ Coverage   92.39%   92.39%   +<.01%     
==========================================
  Files         166      166              
  Lines       52408    52410       +2     
==========================================
+ Hits        48422    48424       +2     
  Misses       3986     3986
Flag Coverage Δ
#multiple 90.82% <100%> (ø) ⬆️
#single 42.88% <75%> (ø) ⬆️
Impacted Files Coverage Δ
pandas/core/arrays/categorical.py 95.97% <100%> (ø) ⬆️
pandas/core/series.py 93.69% <100%> (+0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update df96f12...561b353. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Feb 16, 2019

Codecov Report

Merging #25344 into 0.24.x will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           0.24.x   #25344      +/-   ##
==========================================
+ Coverage   92.39%   92.39%   +<.01%     
==========================================
  Files         166      166              
  Lines       52408    52410       +2     
==========================================
+ Hits        48422    48424       +2     
  Misses       3986     3986
Flag Coverage Δ
#multiple 90.82% <100%> (ø) ⬆️
#single 42.88% <75%> (ø) ⬆️
Impacted Files Coverage Δ
pandas/core/arrays/categorical.py 95.97% <100%> (ø) ⬆️
pandas/core/series.py 93.69% <100%> (+0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update df96f12...561b353. Read the comment docs.

@jreback jreback merged commit 247594e into pandas-dev:0.24.x Feb 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Categorical Categorical Data Type
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants