BUG: pandas.cut should disallow overlapping IntervalIndex bins

[charlesdong1991]

• closes BUG: pandas.cut should disallow overlapping IntervalIndex bins #23980
• tests added / passed
• passes git diff upstream/master -u -- "*.py" | flake8 --diff
• whatsnew entry

[pep8speaks]

Hello @charlesdong1991! Thanks for updating the PR.

• There are no PEP8 issues in the file pandas/core/reshape/tile.py !

• There are no PEP8 issues in the file pandas/tests/reshape/test_tile.py !

Comment last updated on November 30, 2018 at 08:17 Hours UTC

[codecov]

Codecov Report

Merging #23999 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master   #23999      +/-   ##
==========================================
+ Coverage    92.3%   92.31%   +<.01%     
==========================================
  Files         161      161              
  Lines       51555    51550       -5     
==========================================
- Hits        47589    47587       -2     
+ Misses       3966     3963       -3

Flag	Coverage Δ
#multiple	90.7% <100%> (ø)	⬆️
#single	42.44% <0%> (ø)	⬆️

Impacted Files	Coverage Δ
pandas/core/reshape/tile.py	94.76% <100%> (+0.03%)	⬆️
pandas/core/arrays/timedeltas.py	96% <0%> (+0.04%)	⬆️
pandas/core/tools/datetimes.py	85.53% <0%> (+0.08%)	⬆️
pandas/core/indexes/timedeltas.py	90.11% <0%> (+0.5%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7653a6b...4bfcea2. Read the comment docs.

[jschendel]

Thanks! Looks good overall. A couple comments:

• Can you add a whatsnew note to 0.24.0 under the Reshaping subsection of the Bug Fixes section?
• Can you add "Must be non-overlapping." to cut docstring, at the end of the IntervalIndex portion of the bins parameter description?

[charlesdong1991]

Hi, @jschendel , thanks for the review and advices!! As for Can you add a whatsnew note to 0.24.0 under the Reshaping subsection of the Bug Fixes section?, I am not sure if I did it correctly (what i did was just tick the whatsnew entry above). Please give me more hints if it's not what you meant, sorry that I am not familiar with this part. And thanks again!

[jschendel]

For the whatsnew entry, you'll need to edit the /doc/source/whatsnew/v0.24.0.rst file at around line 1485 to add an entry along the lines of:

- Bug in :func:`cut` with ``bins`` as an overlapping ``IntervalIndex`` where multiple bins were returned per item instead of raising a ``ValueError`` (:issue:`23980`)

[charlesdong1991]

@jschendel , ahh, I see!! Thank you very much, added!

[jschendel]

thanks @charlesdong1991!