unpin openpyxl #23361
unpin openpyxl #23361
Conversation
Codecov Report
@@ Coverage Diff @@
## master #23361 +/- ##
=======================================
Coverage 92.18% 92.18%
=======================================
Files 161 161
Lines 51155 51155
=======================================
Hits 47157 47157
Misses 3998 3998
Continue to review full report at Codecov.
|
gfyoung
added
Build
ci/azure-27-compat.yaml
Outdated
| @@ -8,7 +8,7 @@ dependencies: | |||
| - jinja2=2.8 | |||
| - numexpr=2.6.1 | |||
| - numpy=1.12.0 | |||
| - openpyxl=2.5.5 | |||
There was a problem hiding this comment.
can you leave this pin here
|
thanks @alimcmaster1 |
|
@jreback this is strange - this seems to have gone green on Azure despite the fact https://dev.azure.com/pandas-dev/pandas/_build/results?buildId=2029&view=ms.vss-test-web.test-result-details tests seem to be failing on MacOS-35, or am I missing something? Previous commit to master has no mention of these test failures so my commit looks to be the suspect. This seems to be related: Do we want to fail the build if tests fail ( i'm guessing yes ) current behaviour seems to be no? |
…y_tests * repo_org/master: (52 commits) ENH: Allow rename_axis to specify index and columns arguments (pandas-dev#20046) STY: proposed isort settings [ci skip] [skip ci] [ciskip] [skipci] (pandas-dev#23366) MAINT: Remove extraneous test.parquet file CLN: Follow-up comments to pandas-devgh-23392 (pandas-dev#23401) BUG GH23282 calling min on series of NaT returns NaT (pandas-dev#23289) unpin openpyxl (pandas-dev#23361) REF: collect ops dispatch functions in one place, try to de-duplicate SparseDataFrame methods (pandas-dev#23060) CLN: Remove pandas.tools module (pandas-dev#23376) CLN: Remove some dtype methods from API (pandas-dev#23390) CLN: Cleanup toplevel namespace shims (pandas-dev#23386) DOC: fixup whatsnew note for GH21394 (pandas-dev#23355) Fix import format at pandas/tests/extension directory (pandas-dev#23365) DOC: Remove Series.sortlevel from api.rst (pandas-dev#23395) API: Disallow dtypes w/o frequency when casting (pandas-dev#23392) BUG/TST/REF: Datetimelike Arithmetic Methods (pandas-dev#23215) STYLE: lint add np.nan* funcs to cython_table (pandas-dev#22109) Run Isort on tests/util single PR (pandas-dev#23347) BUG: Fix date_range overflow (pandas-dev#23345) Run Isort on tests/arrays single PR (pandas-dev#23346) ...
|
@TomAugspurger thought I would also bring my above comment to your attention. Do you want me to create an issue? Pretty sure we want azure pipeline to fail if tests fail? |
|
Yeah, we want the CI status to be failed when the tests fails. Skimming microsoft/azure-pipelines-tasks#1268 didn't make sense to me. I suppose we could only publish tests results if there's not a failure? |
passes
git diff upstream/master -u -- "*.py" | flake8 --diffFollow up from BLD: Fix openpyxl to 2.5.5 #22601.
Confirmed with openpyxl this bug was fixed in version 2.5.7 see bitbucket issue here
This was release 13th Sept -> https://pypi.org/project/openpyxl/#history