DOC: Updating Series.agg docstring #22474
Conversation
jorisvandenbossche
changed the title
|
Thanks for the PR! |
Codecov Report
@@ Coverage Diff @@
## master #22474 +/- ##
=======================================
Coverage 92.04% 92.04%
=======================================
Files 169 169
Lines 50740 50740
=======================================
Hits 46705 46705
Misses 4035 4035
Continue to review full report at Codecov.
|
pandas/core/series.py
Outdated
| @@ -3046,21 +3046,21 @@ def _gotitem(self, key, ndim, subset=None): | |||
| Examples | |||
| -------- | |||
|
|
|||
| >>> s = pd.Series(np.random.randn(10)) | |||
| >>> s = pd.Series(range(1,10,1)) | |||
There was a problem hiding this comment.
As it doesn't make a difference for the example, I'd use [1, 2, 3, 4] instead of range (it makes the example easier to understand). In any case, please check pep8 in the examples, there are missing spaces after the commas.
There was a problem hiding this comment.
Can you also show >>> s after creating it, and remove the blank line between the examples title and the code.
pandas/core/series.py
Outdated
|
|
||
| pandas.Series.apply : Invoke function on a Series. | ||
| pandas.Series.transform : Transform function producing | ||
| a Series with like indexes. |
There was a problem hiding this comment.
I think this should have the standard 4 spaces indentation.
datapythonista
changed the title
|
Thanks both for the comments. Yes @jorisvandenbossche map doc string was already passing. @datapythonista update as per your comments, let me know if there is anything else, thanks |
|
The failure on travis is an unrelated build issue (and already happening on master as well), so merging Thanks a lot @alimcmaster1 ! |
|
Thanks both!! |
With reference to: #22459. I have fixed up the agg/map doc strings for
pandas/core/series.pyso they now pass our doc tests. CC @jorisvandenbosscheThanks,