-
-
Notifications
You must be signed in to change notification settings - Fork 17.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Array Interface and Categorical internals Refactor #19268
Merged
TomAugspurger
merged 43 commits into
pandas-dev:master
from
TomAugspurger:pandas-array-interface-3
Feb 2, 2018
Merged
Changes from 1 commit
Commits
Show all changes
43 commits
Select commit
Hold shift + click to select a range
2ef5216
REF: Define extension base classes
TomAugspurger 57e8b0f
Updated for comments
TomAugspurger 01bd42f
Remove metaclasses from PeriodDtype and IntervalDtype
TomAugspurger ce81706
Fixup form_blocks rebase
TomAugspurger 87a70e3
Restore concat casting cat -> object
TomAugspurger 8c61886
Remove _slice, clarify semantics around __getitem__
TomAugspurger cb41803
Document and use take.
TomAugspurger 65d5a61
Clarify type, kind, init
TomAugspurger 57c749b
Remove base
TomAugspurger 6736b0f
API: Remove unused __iter__ and get_values
TomAugspurger e4acb59
API: Implement repr and str
TomAugspurger 0e9337b
Merge remote-tracking branch 'upstream/master' into pandas-array-inte…
TomAugspurger df68f3b
Remove default value_counts for now
TomAugspurger 2746a43
Fixed merge conflicts
TomAugspurger 34d2b99
Remove implementation of construct_from_string
TomAugspurger a484d61
Example implementation of take
TomAugspurger 04b2e72
Cleanup ExtensionBlock
TomAugspurger df0fa12
Merge remote-tracking branch 'upstream/master' into pandas-array-inte…
TomAugspurger e778053
Pass through ndim
TomAugspurger d15a722
Use series._values
TomAugspurger b5f736d
Removed repr, updated take doc
TomAugspurger 240e8f6
Various cleanups
TomAugspurger f9b0b49
Handle get_values, to_dense, is_view
TomAugspurger 7913186
Docs
TomAugspurger df18c3b
Remove is_extension, is_bool
TomAugspurger ab2f045
Sparse formatter
TomAugspurger 520876f
Revert "Sparse formatter"
TomAugspurger 4dfa39c
Unbox SparseSeries
TomAugspurger e252103
Added test for sparse consolidation
TomAugspurger 7110b2a
Docs
TomAugspurger c59dca0
Merge remote-tracking branch 'upstream/master' into pandas-array-inte…
TomAugspurger fc688a5
Moved to errors
TomAugspurger fbc8466
Handle classmethods, properties
TomAugspurger 030bb19
Use our AbstractMethodError
TomAugspurger 0f4c2d7
Lint
TomAugspurger f9316e0
Cleanup
TomAugspurger 9c06b13
Move ndim validation to a method.
TomAugspurger 7d2cf9c
Try this
TomAugspurger afae8ae
Make ExtensionBlock._holder a property
TomAugspurger cd0997e
Make _holder a property for all
TomAugspurger 1d6eb04
Refactored validate_ndim
TomAugspurger 92aed49
fixup! Refactored validate_ndim
TomAugspurger 34134f2
lint
TomAugspurger File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cc @jbrockmendel. Pretty sure this is what you had in mind. Agreed it's cleaner.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(needed a followup commit to use
self.ndim
a few lines down.)