MAINT: Clean up pandas/util/testing.py #16271
Conversation
| @@ -571,8 +571,7 @@ def test_groupby_with_timezone_selection(self): | |||
| def test_timezone_info(self): | |||
| # GH 11682 | |||
| # Timezone info lost when broadcasting scalar datetime to DataFrame | |||
| tm._skip_if_no_pytz() | |||
| import pytz | |||
| pytz = pytest.importorskip("pytz") | |||
There was a problem hiding this comment.
actually we should remove this entirely
we require pytz (prob lots of skips related to pytz in the codebase - should remove all of them)
There was a problem hiding this comment.
Okay, so just assume we have pytz installed?
There was a problem hiding this comment.
see if anything breaks when these are installed
| @@ -376,7 +376,7 @@ def test_constructor_datetime64_tzformat(self): | |||
| tz='Asia/Tokyo') | |||
| tm.assert_numpy_array_equal(idx.asi8, expected_i8.asi8) | |||
|
|
|||
| tm._skip_if_no_dateutil() | |||
| pytest.importorskip("dateutil") | |||
There was a problem hiding this comment.
these are also required so again can remove
There was a problem hiding this comment.
Okay, so just assume we have dateutil installed?
There was a problem hiding this comment.
see if anything breaks when these are installed
Codecov Report
@@ Coverage Diff @@
## master #16271 +/- ##
==========================================
+ Coverage 90.32% 90.34% +0.02%
==========================================
Files 167 167
Lines 50908 50872 -36
==========================================
- Hits 45981 45961 -20
+ Misses 4927 4911 -16
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #16271 +/- ##
==========================================
+ Coverage 90.34% 90.36% +0.02%
==========================================
Files 167 167
Lines 50908 50872 -36
==========================================
- Hits 45994 45973 -21
+ Misses 4914 4899 -15
Continue to review full report at Codecov.
|
gfyoung
force-pushed
the
util-testing-clean-up
branch
from
2c987d2
to
42ec6ff
Compare
Transform testing methods to use more pytest idiom. Also, assume that dateutil and pytz are installed for testing because there are core dependencies for pandas.
gfyoung
force-pushed
the
util-testing-clean-up
branch
from
42ec6ff
to
f4a1468
Compare
|
@jreback : Not sure what |
|
@gfyoung yeah I am about ready to disable codecov. It is pretty bogus. I haven't been able to make it use the latest master as the comparison (not really sure why) and their help services are not very helpful :< if you want to have a look at other code coverage services we could easily switch. |
|
thanks! |
Transform testing methods to use more pytest idiom. Also, assume that dateutil and pytz are installed for testing because there are core dependencies for pandas.
Transform testing methods to use more pytest idiom. Also, assume that dateutil and pytz are installed for testing because there are core dependencies for pandas.
Transform testing methods to use more pytest idiom. Also, assume that dateutil and pytz are installed for testing because there are core dependencies for pandas.
Transform testing methods to use more
pytestidiom.xref #15990.