DEPR: allow options for using bottleneck/numexpr #16157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #16157 +/- ##
==========================================
+ Coverage 90.85% 90.87% +0.01%
==========================================
Files 159 162 +3
Lines 50783 50816 +33
==========================================
+ Hits 46141 46178 +37
+ Misses 4642 4638 -4
Continue to review full report at Codecov.
|
crayxt
reviewed
Apr 27, 2017
pandas/core/config_init.py
Outdated
|
|
||
| use_bottleneck_doc = """ | ||
| : bool | ||
| Use the bottleneck library to accelearte if its installed, default is True |
deprecate pd.computation.expressions.set_use_numexpr()
|
cc @jorisvandenbossche |
|
LGTM |
doc/source/options.rst
Outdated
| @@ -425,6 +425,10 @@ mode.use_inf_as_null False True means treat None, NaN, -IN | |||
| INF as null (old way), False means | |||
| None and NaN are null, but INF, -INF | |||
| are not null (new way). | |||
| compute.use_bottleneck True Use the bottleneck library to accelerate | |||
| computation if its installed | |||
doc/source/options.rst
Outdated
| compute.use_bottleneck True Use the bottleneck library to accelerate | ||
| computation if its installed | ||
| compute.use_numexpr True Use the numexpr library to accelerate | ||
| computation if its installed |
pandas/core/config_init.py
Outdated
|
|
||
| use_bottleneck_doc = """ | ||
| : bool | ||
| Use the bottleneck library to accelearte if its installed, default is True |
There was a problem hiding this comment.
same here and below about 'its'
| # set/unset to use bottleneck | ||
| global _USE_BOTTLENECK | ||
| if _BOTTLENECK_INSTALLED: | ||
| _USE_BOTTLENECK = v |
There was a problem hiding this comment.
Should we warn here if v is False and bottleneck is not installed ?
|
| @@ -35,6 +36,9 @@ def set_use_numexpr(v=True): | |||
| global _USE_NUMEXPR | |||
| if _NUMEXPR_INSTALLED: | |||
| _USE_NUMEXPR = v | |||
| elif v: | |||
| warnings.warn("trying to set the option to use numexpr, " | |||
| "but it is not installed!") | |||
There was a problem hiding this comment.
I know I suggested this, but, I think this one will be triggered by default if you don't have numexpr installed? (just by importing pandas, I mean, not only when setting the option manually when you don't have it installed)
There was a problem hiding this comment.
yep, just noticed that. going to take this out.
TomAugspurger
approved these changes
Apr 27, 2017
1 task
pcluo
pushed a commit
to pcluo/pandas
that referenced
this pull request
May 22, 2017
* DEPR: allow options for using bottleneck/numexpr deprecate pd.computation.expressions.set_use_numexpr() * DEPR: pandas.types.concat.union_categoricals in favor of pandas.api.type.union_categoricals closes pandas-dev#16140
gfyoung
added a commit
to forking-repos/pandas
that referenced
this pull request
Oct 27, 2018
Removes the following: * pandas.types * pandas.computation * pandas.util.decorators xref pandas-devgh-16157. xref pandas-devgh-16250.
gfyoung
added a commit
to forking-repos/pandas
that referenced
this pull request
Oct 28, 2018
Removes the following: * pandas.types * pandas.computation * pandas.util.decorators xref pandas-devgh-16157. xref pandas-devgh-16250.
jreback
pushed a commit
that referenced
this pull request
Oct 28, 2018
tm9k1
pushed a commit
to tm9k1/pandas
that referenced
this pull request
Nov 19, 2018
Removes the following: * pandas.types * pandas.computation * pandas.util.decorators xref pandas-devgh-16157. xref pandas-devgh-16250.
Pingviinituutti
pushed a commit
to Pingviinituutti/pandas
that referenced
this pull request
Feb 28, 2019
Removes the following: * pandas.types * pandas.computation * pandas.util.decorators xref pandas-devgh-16157. xref pandas-devgh-16250.
Pingviinituutti
pushed a commit
to Pingviinituutti/pandas
that referenced
this pull request
Feb 28, 2019
Removes the following: * pandas.types * pandas.computation * pandas.util.decorators xref pandas-devgh-16157. xref pandas-devgh-16250.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
deprecate pd.computation.expressions.set_use_numexpr()
supersedes #16140