Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINT: Remove self.assertRaisesRegexp from testing #16113

Conversation

gfyoung
Copy link
Member

@gfyoung gfyoung commented Apr 24, 2017

Title is self-explanatory.

Partially addresses #15990.

@codecov
Copy link

codecov bot commented Apr 24, 2017

Codecov Report

Merging #16113 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #16113      +/-   ##
==========================================
- Coverage   90.84%   90.84%   -0.01%     
==========================================
  Files         159      159              
  Lines       50771    50768       -3     
==========================================
- Hits        46122    46119       -3     
  Misses       4649     4649
Flag Coverage Δ
#multiple 88.62% <ø> (-0.01%) ⬇️
#single 40.33% <ø> (-0.01%) ⬇️
Impacted Files Coverage Δ
pandas/util/testing.py 79.07% <ø> (-0.06%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 844013b...c29715f. Read the comment docs.

@jorisvandenbossche jorisvandenbossche merged commit f8b25c2 into pandas-dev:master Apr 24, 2017
@jorisvandenbossche
Copy link
Member

@gfyoung thanks!

@jorisvandenbossche jorisvandenbossche added Clean Testing pandas testing functions or related to the test suite labels Apr 24, 2017
@jorisvandenbossche jorisvandenbossche added this to the 0.20.0 milestone Apr 24, 2017
@gfyoung gfyoung deleted the assert-raises-regexp-refactor branch April 24, 2017 20:05
pcluo pushed a commit to pcluo/pandas that referenced this pull request May 22, 2017
* MAINT: Remove self.assertRaisesRegexp from testing

* MAINT: Do not add static assert methods to TestCase
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Clean Testing pandas testing functions or related to the test suite
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants