Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINT: Remove assertIsInstance from testing #16081

Merged
merged 1 commit into from
Apr 21, 2017

Conversation

gfyoung
Copy link
Member

@gfyoung gfyoung commented Apr 21, 2017

Title is self-explanatory.

Partially addresses #15990.

@codecov
Copy link

codecov bot commented Apr 21, 2017

Codecov Report

Merging #16081 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #16081      +/-   ##
==========================================
- Coverage   90.82%   90.82%   -0.01%     
==========================================
  Files         159      159              
  Lines       50791    50784       -7     
==========================================
- Hits        46132    46124       -8     
- Misses       4659     4660       +1
Flag Coverage Δ
#multiple 88.6% <100%> (-0.01%) ⬇️
#single 40.36% <61.9%> (ø) ⬆️
Impacted Files Coverage Δ
pandas/util/testing.py 79.62% <100%> (-0.14%) ⬇️
pandas/core/common.py 90.68% <0%> (-0.35%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ff00b55...ccf75ae. Read the comment docs.

@codecov
Copy link

codecov bot commented Apr 21, 2017

Codecov Report

Merging #16081 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #16081      +/-   ##
==========================================
- Coverage   90.82%   90.82%   -0.01%     
==========================================
  Files         159      159              
  Lines       50791    50784       -7     
==========================================
- Hits        46132    46124       -8     
- Misses       4659     4660       +1
Flag Coverage Δ
#multiple 88.6% <100%> (-0.01%) ⬇️
#single 40.36% <61.9%> (ø) ⬆️
Impacted Files Coverage Δ
pandas/util/testing.py 79.62% <100%> (-0.14%) ⬇️
pandas/core/common.py 90.68% <0%> (-0.35%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ff00b55...ccf75ae. Read the comment docs.

@jorisvandenbossche jorisvandenbossche added Clean Testing pandas testing functions or related to the test suite labels Apr 21, 2017
@jreback jreback added this to the 0.20.0 milestone Apr 21, 2017
@jreback jreback merged commit 8c7b973 into pandas-dev:master Apr 21, 2017
@jreback
Copy link
Contributor

jreback commented Apr 21, 2017

thanks!

@gfyoung gfyoung deleted the assertIsInstance-remove branch April 21, 2017 10:19
pcluo pushed a commit to pcluo/pandas that referenced this pull request May 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Clean Testing pandas testing functions or related to the test suite
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants