MAINT: Remove assertIsNotNone from testing #16027
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gfyoung
changed the title
Codecov Report
@@ Coverage Diff @@
## master #16027 +/- ##
==========================================
- Coverage 90.99% 90.99% -0.01%
==========================================
Files 153 153
Lines 50471 50469 -2
==========================================
- Hits 45928 45926 -2
Misses 4543 4543
Continue to review full report at Codecov.
|
jorisvandenbossche
approved these changes
Apr 17, 2017
|
@gfyoung Thanks! If you would do further PRs like this, could you leave comments as is? (if it is just capitalisation or punctuation, the diff is already large enough ;-)) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Title is self-explanatory.
Also removes some vestigial
assertIsNotcalls missed in #16024.Partially addresses #15990.