Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ENH: Allow to_sql to recognize single sql type #11886 #13252

Closed
wants to merge 7 commits into from
Closed

ENH: Allow to_sql to recognize single sql type #11886 #13252

wants to merge 7 commits into from

Conversation

RahulHP
Copy link
Contributor

@RahulHP RahulHP commented May 21, 2016 •
edited by jorisvandenbossche
Loading

Follow-up in #13614

This solves #11886
It checks whether the passed dtype variable is a dictionary.
If not, it creates a new dictionary with keys as the columns of the dataframe.
It then passes this dictionary to the pandasSQL_builder.

@RahulHP RahulHP mentioned this pull request May 21, 2016
Closed
@jreback jreback added the IO SQL to_sql, read_sql, read_sql_query label May 21, 2016
@RahulHP
Copy link
Contributor Author

RahulHP commented May 22, 2016

Could someone please tell me why this build failed? (https://travis-ci.org/pydata/pandas/jobs/132018332)
I can't find any error in the logs.

@jreback
Copy link
Contributor

jreback commented May 22, 2016

you have pep issues

https://travis-ci.org/pydata/pandas/jobs/132018332

@RahulHP
Copy link
Contributor Author

RahulHP commented May 23, 2016

pandas/io/tests/test_sql.py:2050:80: E501 line too long (80 > 79 characters) pandas/io/tests/test_sql.py:2051:53: E127 continuation line over-indented for visual indent
How should I fix these lines?
https://github.com/pydata/pandas/pull/13252/files#diff-052a926a9b2c33a84e27d51c8fad3466R2050

jorisvandenbossche
jorisvandenbossche reviewed May 23, 2016
View reviewed changes
pandas/io/tests/test_sql.py
df = DataFrame(data,columns=cols)
df.to_sql('single_dtype_test', self.conn, dtype='STRING')
self.assertEqual(self._get_sqlite_column_type('single_dtype_test', 'A'),
'STRING')
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can do eg

        self.assertEqual(
            self._get_sqlite_column_type('single_dtype_test', 'A'), 'STRING')

@RahulHP RahulHP closed this May 27, 2016
@jorisvandenbossche
Copy link
Member

@RahulHP Is there a reason you closed this?

To clean up the unwanted commits here, you can do:

git fetch upstream/master
git rebase upstream/master
git push -f origin/master

RahulHP and others added 3 commits May 27, 2016 22:56
@RahulHP
ENH: Allow to_sql to recognize single sql type pandas-dev#11886
ed726cd
@RahulHP
ENH: support decimal option in PythonParser pandas-dev#12933
1a73316 
closes pandas-dev#12933

Author: Camilo Cota <ccota@riplife.es>

Closes pandas-dev#13189 from camilocot/12933 and squashes the following commits:

465272e [Camilo Cota] Benchmark decimal option in read_csv for c engine
9f42d0c [Camilo Cota] double backticks around decimal and engine='python'
dc8ca62 [Camilo Cota] fix test_empty_decimal_marker comment
49613fe [Camilo Cota] Assert read_csv error message in test_empty_decimal_marker
d821052 [Camilo Cota] fix test_empty_decimal_marker comment
f71509d [Camilo Cota] Include descritive what's new line
803356e [Camilo Cota] set nonnum regex in init method
1472d80 [Camilo Cota] Include the issue number in what's new
b560fda [Camilo Cota] Fix what's new
dc7acd1 [Camilo Cota] ENH: support decimal option in PythonParser pandas-dev#12933
@RahulHP
ENH: Allow to_sql to recognize single sql type pandas-dev#11886
20f0c21 
PEP pandas-dev#3
@RahulHP
Copy link
Contributor Author

RahulHP commented May 27, 2016

I thought someone else would be better equipped to handle this. I have tried it but I seem to have trouble with the rebase related commands.

I'll try it again now.

@RahulHP
parser
a9798f9
@RahulHP
Lint
639f150
@RahulHP
ENH: Allow to_sql to recognize single sql type pandas-dev#11886
9d7c7f6 
ENH: support decimal option in PythonParser pandas-dev#12933

closes pandas-dev#12933

Author: Camilo Cota <ccota@riplife.es>

Closes pandas-dev#13189 from camilocot/12933 and squashes the following commits:

465272e [Camilo Cota] Benchmark decimal option in read_csv for c engine
9f42d0c [Camilo Cota] double backticks around decimal and engine='python'
dc8ca62 [Camilo Cota] fix test_empty_decimal_marker comment
49613fe [Camilo Cota] Assert read_csv error message in test_empty_decimal_marker
d821052 [Camilo Cota] fix test_empty_decimal_marker comment
f71509d [Camilo Cota] Include descritive what's new line
803356e [Camilo Cota] set nonnum regex in init method
1472d80 [Camilo Cota] Include the issue number in what's new
b560fda [Camilo Cota] Fix what's new
dc7acd1 [Camilo Cota] ENH: support decimal option in PythonParser pandas-dev#12933

ENH: Allow to_sql to recognize single sql type pandas-dev#11886

PEP pandas-dev#3
@RahulHP
Merge branch 'master' of https://github.com/RahulHP/pandas
a683a24
@jorisvandenbossche
Copy link
Member

@RahulHP You still have some commits that should not be in here. Normally, by doing exactly:

git fetch upstream/master
git rebase upstream/master
git push -f origin/master

it should be OK. If this does not work, can you show the output of those commands?

@jorisvandenbossche
Copy link
Member

@RahulHP Do you have time to update this?

@RahulHP
Copy link
Contributor Author

RahulHP commented Jul 10, 2016

No I don't, sorry for the trouble.

@jorisvandenbossche
Copy link
Member

@RahulHP No problem, I will rebase this for you then, as it was a good enhancement!

@jorisvandenbossche jorisvandenbossche added this to the 0.19.0 milestone Jul 11, 2016
@jorisvandenbossche jorisvandenbossche mentioned this pull request Jul 11, 2016
Merged
@jorisvandenbossche jorisvandenbossche modified the milestones: No action, 0.19.0 Jul 11, 2016
@jorisvandenbossche
Copy link
Member

Rebased in #13614

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Enhancement IO SQL to_sql, read_sql, read_sql_query
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@RahulHP @jreback @jorisvandenbossche