Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TST/CLN: remove assert_isinstance #10458

Merged
merged 1 commit into from
Jun 30, 2015
Merged

Conversation

sinhrks
Copy link
Member

@sinhrks sinhrks commented Jun 28, 2015

testing.py has assert_isinstance and assertIsInstance duplicately, and each test case uses either of them by choice.

Changed to use assertIsInstance in all cases, and make assert_isinstance show warning.

@sinhrks sinhrks added the Testing pandas testing functions or related to the test suite label Jun 28, 2015
@sinhrks sinhrks added this to the 0.17.0 milestone Jun 28, 2015
jreback added a commit that referenced this pull request Jun 30, 2015
TST/CLN: remove assert_isinstance
@jreback jreback merged commit 71ac2eb into pandas-dev:master Jun 30, 2015
@jreback
Copy link
Contributor

jreback commented Jun 30, 2015

thanks!

@sinhrks sinhrks deleted the assert_isinstance branch June 30, 2015 13:03
gfyoung added a commit to forking-repos/pandas that referenced this pull request Mar 11, 2017
jreback pushed a commit that referenced this pull request Mar 11, 2017
AnkurDedania pushed a commit to AnkurDedania/pandas that referenced this pull request Mar 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Testing pandas testing functions or related to the test suite
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants