Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI: sql tests failures casued by pymysql #36465

Closed
fangchenli opened this issue Sep 19, 2020 · 2 comments
Closed

CI: sql tests failures casued by pymysql #36465

fangchenli opened this issue Sep 19, 2020 · 2 comments
Labels
CI Continuous Integration Dependencies Required and optional dependencies IO SQL to_sql, read_sql, read_sql_query

Comments

@fangchenli
Copy link
Member

fangchenli commented Sep 19, 2020 •
edited
Loading

While working on #36443, I found several sql tests failures related to the latest pymysql and sqlalchemy (could be one of them or both, not sure). See https://travis-ci.org/github/pandas-dev/pandas/jobs/728346186

FAILED pandas/tests/io/test_sql.py::TestMySQLAlchemy::test_to_sql_with_negative_npinf[load_iris_data0-input0]

FAILED pandas/tests/io/test_sql.py::TestMySQLAlchemy::test_to_sql_with_negative_npinf[load_iris_data0-input1]

FAILED pandas/tests/io/test_sql.py::TestMySQLAlchemy::test_to_sql_with_negative_npinf[load_iris_data0-input2]

FAILED pandas/tests/io/test_sql.py::TestMySQLAlchemyConn::test_to_sql_with_negative_npinf[load_iris_data0-input0]

FAILED pandas/tests/io/test_sql.py::TestMySQLAlchemyConn::test_to_sql_with_negative_npinf[load_iris_data0-input1]

FAILED pandas/tests/io/test_sql.py::TestMySQLAlchemyConn::test_to_sql_with_negative_npinf[load_iris_data0-input2]

= 6 failed, 76075 passed, 1025 skipped, 1209 xfailed, 6 xpassed, 264 warnings in 1626.88s 

pymysql                   0.10.1             pyh9f0ad1d_0    conda-forge
sqlalchemy                1.3.19           py37h8f50634_0    conda-forge

Now those two packages have been pinned to their minimal support versions.

pymysql                   0.7.11                     py_0    conda-forge
sqlalchemy                1.3.0            py37h14c3975_0    conda-forge

Update

The problem is from pymysql. #34431 handled inf dtype for to_sql. But it failed to capture that error while using the latest pymysql as sql driver. The test failed for pymysql>=0.10
@fangchenli fangchenli added Bug Needs Triage Issue that has not been reviewed by a pandas team member labels Sep 19, 2020
@dsaxton dsaxton added CI Continuous Integration and removed Bug Needs Triage Issue that has not been reviewed by a pandas team member labels Sep 19, 2020
fangchenli added a commit to fangchenli/pandas that referenced this issue Oct 4, 2020
@fangchenli
CI: unpin sql to verify the bugs pandas-dev#36465
ce2e8d4
@fangchenli fangchenli mentioned this issue Oct 4, 2020
Merged
@fangchenli fangchenli added IO SQL to_sql, read_sql, read_sql_query Dependencies Required and optional dependencies labels Oct 4, 2020
@fangchenli fangchenli changed the title CI: sql tests failures CI: sql tests failures casued by pymysql Oct 4, 2020
jreback pushed a commit that referenced this issue Oct 10, 2020
@fangchenli
CI: pin pymysql #36465 (#36847)
50d61b2 
* CI: unpin sql to verify the bugs #36465

* CI: pin sqlalchemy

* CI: pin pymsql

* CI: pin sqlalchemy

* CI: pin pymysql

* CI: pin pymysql

* CI: add note
jbrockmendel pushed a commit to jbrockmendel/pandas that referenced this issue Oct 10, 2020
@fangchenli @jbrockmendel
CI: pin pymysql pandas-dev#36465 (pandas-dev#36847)
81ac02a 
* CI: unpin sql to verify the bugs pandas-dev#36465

* CI: pin sqlalchemy

* CI: pin pymsql

* CI: pin sqlalchemy

* CI: pin pymysql

* CI: pin pymysql

* CI: add note
jreback pushed a commit that referenced this issue Oct 11, 2020
@jbrockmendel @krajatcl
@fangchenli @micahjsmith
REF/TYP: use OpsMixin for DataFrame (#37044)
89cc5bf 
* REF/TYP: use OpsMixin for arithmetic methods

* REF: separate arith_method_FRAME from flex_arith_method_FRAME

* whatsnew

* REF/TYP: use OpsMixin for logical methods (#36964)

* TST: insert 'match' to bare pytest raises in pandas/tests/tools/test_to_datetime.py (#37027)

* TST: insert 'match' to bare pytest raises in pandas/tests/test_flags.py (#37026)

Co-authored-by: Rajat Bishnoi <rajat.b@greyorange.com>

* TYP: generic, series, frame (#36989)

* CI: pin pymysql #36465 (#36847)

* CI: unpin sql to verify the bugs #36465

* CI: pin sqlalchemy

* CI: pin pymsql

* CI: pin sqlalchemy

* CI: pin pymysql

* CI: pin pymysql

* CI: add note

* CLN/REF: de-duplicate DatetimeTZBlock.setitem (#37019)

* REF/TYP: define NDFrame numeric methods non-dynamically (#37017)

* CLN: require td64 in TimedeltaBlock (#37018)

* BUG: Raise ValueError instead of bare Exception in sanitize_array (#35769)

* CLN: collected cleanups, warning suppression in tests (#37021)

* REF/TYP: use OpsMixin for DataFrame

* CLN: remove get_op_name

* mypy fixup

* de-privatize

Co-authored-by: krajatcl <53620269+krajatcl@users.noreply.github.com>
Co-authored-by: Rajat Bishnoi <rajat.b@greyorange.com>
Co-authored-by: Fangchen Li <fangchen.li@outlook.com>
Co-authored-by: Micah Smith <micahjsmith@gmail.com>
JulianWgs pushed a commit to JulianWgs/pandas that referenced this issue Oct 26, 2020
@jbrockmendel @krajatcl
@fangchenli @micahjsmith @JulianWgs
REF/TYP: use OpsMixin for DataFrame (pandas-dev#37044)
a39d335 
* REF/TYP: use OpsMixin for arithmetic methods

* REF: separate arith_method_FRAME from flex_arith_method_FRAME

* whatsnew

* REF/TYP: use OpsMixin for logical methods (pandas-dev#36964)

* TST: insert 'match' to bare pytest raises in pandas/tests/tools/test_to_datetime.py (pandas-dev#37027)

* TST: insert 'match' to bare pytest raises in pandas/tests/test_flags.py (pandas-dev#37026)

Co-authored-by: Rajat Bishnoi <rajat.b@greyorange.com>

* TYP: generic, series, frame (pandas-dev#36989)

* CI: pin pymysql pandas-dev#36465 (pandas-dev#36847)

* CI: unpin sql to verify the bugs pandas-dev#36465

* CI: pin sqlalchemy

* CI: pin pymsql

* CI: pin sqlalchemy

* CI: pin pymysql

* CI: pin pymysql

* CI: add note

* CLN/REF: de-duplicate DatetimeTZBlock.setitem (pandas-dev#37019)

* REF/TYP: define NDFrame numeric methods non-dynamically (pandas-dev#37017)

* CLN: require td64 in TimedeltaBlock (pandas-dev#37018)

* BUG: Raise ValueError instead of bare Exception in sanitize_array (pandas-dev#35769)

* CLN: collected cleanups, warning suppression in tests (pandas-dev#37021)

* REF/TYP: use OpsMixin for DataFrame

* CLN: remove get_op_name

* mypy fixup

* de-privatize

Co-authored-by: krajatcl <53620269+krajatcl@users.noreply.github.com>
Co-authored-by: Rajat Bishnoi <rajat.b@greyorange.com>
Co-authored-by: Fangchen Li <fangchen.li@outlook.com>
Co-authored-by: Micah Smith <micahjsmith@gmail.com>
kesmit13 pushed a commit to kesmit13/pandas that referenced this issue Nov 2, 2020
@fangchenli
CI: pin pymysql pandas-dev#36465 (pandas-dev#36847)
af4c764 
* CI: unpin sql to verify the bugs pandas-dev#36465

* CI: pin sqlalchemy

* CI: pin pymsql

* CI: pin sqlalchemy

* CI: pin pymysql

* CI: pin pymysql

* CI: add note
kesmit13 pushed a commit to kesmit13/pandas that referenced this issue Nov 2, 2020
@jbrockmendel @krajatcl
@fangchenli @micahjsmith
REF/TYP: use OpsMixin for DataFrame (pandas-dev#37044)
0b7a1c8 
* REF/TYP: use OpsMixin for arithmetic methods

* REF: separate arith_method_FRAME from flex_arith_method_FRAME

* whatsnew

* REF/TYP: use OpsMixin for logical methods (pandas-dev#36964)

* TST: insert 'match' to bare pytest raises in pandas/tests/tools/test_to_datetime.py (pandas-dev#37027)

* TST: insert 'match' to bare pytest raises in pandas/tests/test_flags.py (pandas-dev#37026)

Co-authored-by: Rajat Bishnoi <rajat.b@greyorange.com>

* TYP: generic, series, frame (pandas-dev#36989)

* CI: pin pymysql pandas-dev#36465 (pandas-dev#36847)

* CI: unpin sql to verify the bugs pandas-dev#36465

* CI: pin sqlalchemy

* CI: pin pymsql

* CI: pin sqlalchemy

* CI: pin pymysql

* CI: pin pymysql

* CI: add note

* CLN/REF: de-duplicate DatetimeTZBlock.setitem (pandas-dev#37019)

* REF/TYP: define NDFrame numeric methods non-dynamically (pandas-dev#37017)

* CLN: require td64 in TimedeltaBlock (pandas-dev#37018)

* BUG: Raise ValueError instead of bare Exception in sanitize_array (pandas-dev#35769)

* CLN: collected cleanups, warning suppression in tests (pandas-dev#37021)

* REF/TYP: use OpsMixin for DataFrame

* CLN: remove get_op_name

* mypy fixup

* de-privatize

Co-authored-by: krajatcl <53620269+krajatcl@users.noreply.github.com>
Co-authored-by: Rajat Bishnoi <rajat.b@greyorange.com>
Co-authored-by: Fangchen Li <fangchen.li@outlook.com>
Co-authored-by: Micah Smith <micahjsmith@gmail.com>
@simonjayhawkins simonjayhawkins mentioned this issue Nov 26, 2020
Closed
@fangchenli fangchenli mentioned this issue Mar 30, 2021
Merged
@jreback jreback added this to the 1.3 milestone Mar 30, 2021
@simonjayhawkins
Copy link
Member

@fangchenli #40696 didn't close this because of the xfail added? removing milestone.

@simonjayhawkins simonjayhawkins removed this from the 1.3 milestone Jun 11, 2021
@mroeschke
Copy link
Member

Looks like test_to_sql_with_negative_npinf has a carve-out for pymysql now so going to close

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
CI Continuous Integration Dependencies Required and optional dependencies IO SQL to_sql, read_sql, read_sql_query
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@jreback @dsaxton @fangchenli @mroeschke @simonjayhawkins