Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Union of indexes of tuples is not sorted #17376

Closed
toobaz opened this issue Aug 30, 2017 · 3 comments
Closed

Union of indexes of tuples is not sorted #17376

toobaz opened this issue Aug 30, 2017 · 3 comments
Labels
good first issue Needs Tests Unit test(s) needed to prevent regressions

Comments

@toobaz
Copy link
Member

toobaz commented Aug 30, 2017

Code Sample, a copy-pastable example if possible

aidx1 = np.array([(1, 'A'), (2, 'A'), (1, 'B'), (2, 'B')],
                 dtype=[('num', int), ('let', 'a1')])
aidx2 = np.array([(1, 'A'), (2, 'A'), (1, 'B'),
                  (2, 'B'), (1, 'C'), (2, 'C')],
                 dtype=[('num', int), ('let', 'a1')])

idx1 = pd.Index(aidx1)
idx2 = pd.Index(aidx2)

idx1.union(idx2)

Result: Index([(1, b'A'), (2, b'A'), (1, b'B'), (2, b'B'), (1, b'C'), (2, b'C')], dtype='object')

This was already known (the example above is copied from the tests), but I don't see it reported anywhere.

Problem description

The Index.union docs states the result is sorted if possible - and it is possible with the above.

Expected Output

In [4]: idx1.union(idx2).sort_values()
Out[4]: Index([(1, b'A'), (1, b'B'), (1, b'C'), (2, b'A'), (2, b'B'), (2, b'C')], dtype='object')

Output of pd.show_versions()

INSTALLED VERSIONS

commit: 0d676a3
python: 3.5.3.final.0
python-bits: 64
OS: Linux
OS-release: 4.9.0-3-amd64
machine: x86_64
processor:
byteorder: little
LC_ALL: None
LANG: it_IT.UTF-8
LOCALE: it_IT.UTF-8

pandas: 0.21.0.dev+405.g0d676a3cc
pytest: 3.0.6
pip: 9.0.1
setuptools: None
Cython: 0.25.2
numpy: 1.12.1
scipy: 0.19.0
pyarrow: None
xarray: None
IPython: 5.1.0.dev
sphinx: 1.5.6
patsy: 0.4.1
dateutil: 2.6.0
pytz: 2017.2
blosc: None
bottleneck: 1.2.1
tables: 3.3.0
numexpr: 2.6.1
feather: 0.3.1
matplotlib: 2.0.2
openpyxl: None
xlrd: 1.0.0
xlwt: 1.1.2
xlsxwriter: 0.9.6
lxml: None
bs4: 4.5.3
html5lib: 0.999999999
sqlalchemy: 1.0.15
pymysql: None
psycopg2: None
jinja2: 2.9.6
s3fs: None
fastparquet: None
pandas_gbq: None
pandas_datareader: 0.2.1

@jreback jreback added 2/3 Compat Bug Reshaping Concat, Merge/Join, Stack/Unstack, Explode labels Aug 30, 2017
@jreback jreback added this to the 0.21.0 milestone Aug 30, 2017
@jreback jreback modified the milestones: 0.21.0, Next Major Release Sep 23, 2017
@toobaz toobaz mentioned this issue Apr 24, 2018
4 tasks
@mroeschke
Copy link
Member

Looks to work on master. Could use a test.

In [35]: aidx1 = np.array([(1, 'A'), (2, 'A'), (1, 'B'), (2, 'B')],
    ...:                  dtype=[('num', int), ('let', 'a1')])
    ...: aidx2 = np.array([(1, 'A'), (2, 'A'), (1, 'B'),
    ...:                   (2, 'B'), (1, 'C'), (2, 'C')],
    ...:                  dtype=[('num', int), ('let', 'a1')])
    ...:
    ...: idx1 = pd.Index(aidx1)
    ...: idx2 = pd.Index(aidx2)
    ...:
    ...: idx1.union(idx2)
Out[35]: Index([(1, b'A'), (1, b'B'), (1, b'C'), (2, b'A'), (2, b'B'), (2, b'C')], dtype='object')

In [36]: pd.__version__
Out[36]: '0.26.0.dev0+565.g8c5941cd5'

@mroeschke mroeschke removed 2/3 Compat Bug Reshaping Concat, Merge/Join, Stack/Unstack, Explode labels Oct 15, 2019
@mroeschke mroeschke added good first issue Needs Tests Unit test(s) needed to prevent regressions labels Oct 15, 2019
@dwhu
Copy link
Contributor

dwhu commented Jan 2, 2020

I believe this test already exists: https://github.com/pandas-dev/pandas/blob/master/pandas/tests/indexes/test_base.py#L1866

@pytest.mark.parametrize(
        "method,expected,sort",
        [
            (
                "intersection",
                np.array(
                    [(1, "A"), (2, "A"), (1, "B"), (2, "B")],
                    dtype=[("num", int), ("let", "a1")],
                ),
                False,
            ),
            (
                "intersection",
                np.array(
                    [(1, "A"), (1, "B"), (2, "A"), (2, "B")],
                    dtype=[("num", int), ("let", "a1")],
                ),
                None,
            ),
            (
                "union",
                np.array(
                    [(1, "A"), (1, "B"), (1, "C"), (2, "A"), (2, "B"), (2, "C")],
                    dtype=[("num", int), ("let", "a1")],
                ),
                None,
            ),
        ],
    )
    def test_tuple_union_bug(self, method, expected, sort):
        index1 = Index(
            np.array(
                [(1, "A"), (2, "A"), (1, "B"), (2, "B")],
                dtype=[("num", int), ("let", "a1")],
            )
        )
        index2 = Index(
            np.array(
                [(1, "A"), (2, "A"), (1, "B"), (2, "B"), (1, "C"), (2, "C")],
                dtype=[("num", int), ("let", "a1")],
            )
        )

        result = getattr(index1, method)(index2, sort=sort)
        assert result.ndim == 1

        expected = Index(expected)
        tm.assert_index_equal(result, expected)

@mroeschke
Copy link
Member

Thanks @dwhu. Yes looks like this case is covered.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Needs Tests Unit test(s) needed to prevent regressions
Projects
None yet
4 participants