Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CLN: cleanup rank tests #15640

Closed
jreback opened this issue Mar 10, 2017 · 3 comments
Closed

CLN: cleanup rank tests #15640

jreback opened this issue Mar 10, 2017 · 3 comments
Labels
Clean Testing pandas testing functions or related to the test suite
Milestone
0.20.0

Comments

@jreback
Copy link
Contributor

jreback commented Mar 10, 2017

we have rank tests in:

Create a new pandas/tests/series/test_rank

  • pandas/tests/series/test_analytics

Create a new pandas/tests/frame/test_rank

  • pandas/tests/frame/test_analytics

  • pandas/tests/test_algos

Let's remove this and split among the other three

  • pandas/tests/test_stats
@jreback jreback added Clean Difficulty Novice Testing pandas testing functions or related to the test suite labels Mar 10, 2017
@jreback jreback added this to the 0.20.0 milestone Mar 10, 2017
@jreback jreback mentioned this issue Mar 10, 2017
Merged
4 tasks
@rouzazari
Copy link
Contributor

@jreback, just so I understand: the end result will have two files (series/test_rank and frame/test_rank), correct?

The rank-related tests from all four source files (series/test_analytics, frame/test_analytics, test_algos, and test_stats) should end up in the relevant test_rank files. All unrelated (i.e. non-rank) tests should remain in the existing files.

@jreback
Copy link
Contributor Author

jreback commented Mar 11, 2017

yes though you might have some common tests in test_algos (if that makes sense)

rouzazari added a commit to rouzazari/pandas that referenced this issue Mar 11, 2017
@rouzazari
CLN: Cleanup tests for .rank()
0d91d8f 
Work in Progress

1. Created new `pandas/tests/series/test_rank` and `pandas/tests/frame/test_rank`
2. Moved tests from `pandas/tests/test_stats` to `series` or `frame`
version of `test_rank`

See pandas-dev#15640
rouzazari added a commit to rouzazari/pandas that referenced this issue Mar 12, 2017
@rouzazari
CLN: Cleanup tests for .rank()
9580af0 
Work in Progress

1. Created new `pandas/tests/series/test_rank` and `pandas/tests/frame/test_rank`
2. Moved tests from `pandas/tests/test_stats` to `series` or `frame`
version of `test_rank`
3. move `rank` tests from `frame/test_analytics` to `frame/test_rank`
4. move `rank` tests from `series/test_analytics` to
`series/test_analytics`

See pandas-dev#15640
@rouzazari rouzazari mentioned this issue Mar 12, 2017
Closed
4 tasks
@rouzazari
Copy link
Contributor

Great. I submitted a PR. I believe the tests that remain in test_algos should remain there because those tests are not specifically related to Series or DataFrame; they seem to be related to testing rank in general.

AnkurDedania pushed a commit to AnkurDedania/pandas that referenced this issue Mar 21, 2017
@rouzazari @AnkurDedania
CLN: Cleanup tests for .rank()
4cb1cd7 
closes pandas-dev#15640

Author: Rouz Azari <rouz.azari@gmail.com>

Closes pandas-dev#15658 from rouzazari/GH15640 and squashes the following commits:

d0a2abc [Rouz Azari] Fixed linting error with datetime.datetime import
9580af0 [Rouz Azari] CLN: Cleanup tests for .rank()
mattip pushed a commit to mattip/pandas that referenced this issue Apr 3, 2017
@rouzazari @mattip
CLN: Cleanup tests for .rank()
ffbd0f5 
closes pandas-dev#15640

Author: Rouz Azari <rouz.azari@gmail.com>

Closes pandas-dev#15658 from rouzazari/GH15640 and squashes the following commits:

d0a2abc [Rouz Azari] Fixed linting error with datetime.datetime import
9580af0 [Rouz Azari] CLN: Cleanup tests for .rank()
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Clean Testing pandas testing functions or related to the test suite
Projects
None yet
Milestone
0.20.0
Development

Successfully merging a pull request may close this issue.

CLN: Cleanup tests for .rank() rouzazari/pandas
2 participants
@jreback @rouzazari