Skip to content

Commit

Permalink
Review related fixes
Browse files Browse the repository at this point in the history
  • Loading branch information
jschendel committed Aug 14, 2017
1 parent 92d8070 commit 017d272
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 7 deletions.
4 changes: 2 additions & 2 deletions doc/source/whatsnew/v0.21.0.txt
Original file line number Diff line number Diff line change
Expand Up @@ -310,7 +310,8 @@ Conversion

- Bug in assignment against datetime-like data with ``int`` may incorrectly converte to datetime-like (:issue:`14145`)
- Bug in assignment against ``int64`` data with ``np.ndarray`` with ``float64`` dtype may keep ``int64`` dtype (:issue:`14001`)
- Bug in the return type of ``IntervalIndex.is_non_overlapping_monotonic``, which returned ``numpy.bool_`` instead of Python ``bool`` (:issue:`17237`)
- Fixed the return type of ``IntervalIndex.is_non_overlapping_monotonic`` to be a Python ``bool`` for consistency with similar attributes/methods. Previously returned a ``numpy.bool_``. (:issue:`17237`)
- Bug in ``IntervalIndex.is_non_overlapping_monotonic`` when intervals are closed on both sides and overlap at a point (:issue:`16560`)

Indexing
^^^^^^^^
Expand Down Expand Up @@ -386,4 +387,3 @@ Other
- Bug in :func:`eval` where the ``inplace`` parameter was being incorrectly handled (:issue:`16732`)
- Bug in ``.isin()`` in which checking membership in empty ``Series`` objects raised an error (:issue:`16991`)
- Bug in :func:`unique` where checking a tuple of strings raised a ``TypeError`` (:issue:`17108`)
- Bug in ``IntervalIndex.is_non_overlapping_monotonic`` when intervals are closed on both sides and overlap at a point (:issue:`16560`)
5 changes: 0 additions & 5 deletions pandas/tests/indexes/test_interval.py
Original file line number Diff line number Diff line change
Expand Up @@ -683,11 +683,6 @@ def f():
pytest.raises(ValueError, f)

def test_is_non_overlapping_monotonic(self):
# Verify that a Python Boolean is returned (GH17237)
for closed in ('left', 'right', 'neither', 'both'):
idx = IntervalIndex.from_breaks(range(4), closed=closed)
assert type(idx.is_non_overlapping_monotonic) is bool

# Should be True in all cases
tpls = [(0, 1), (2, 3), (4, 5), (6, 7)]
for closed in ('left', 'right', 'neither', 'both'):
Expand Down

0 comments on commit 017d272

Please sign in to comment.