Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Improve api.types #274

Merged
merged 3 commits into from
Sep 6, 2022
Merged

ENH: Improve api.types #274

merged 3 commits into from
Sep 6, 2022

Conversation

bashtage
Copy link
Contributor

@bashtage bashtage commented Sep 6, 2022

Clean and improve the typing for api.types
Add tests

  • Tests added: Please use assert_type() to assert the type of any return value

Clean and improve the typing for api.types
Add tests
@bashtage
Copy link
Contributor Author

bashtage commented Sep 6, 2022

xref pandas-dev/pandas#48410

@bashtage
Copy link
Contributor Author

bashtage commented Sep 6, 2022

Removed 2 deprecated is_ functions.
Removed some import x as x import that were only reexports

pandas-stubs/_libs/lib.pyi Outdated Show resolved Hide resolved
pandas-stubs/api/types/__init__.pyi Show resolved Hide resolved
pandas-stubs/api/types/__init__.pyi Show resolved Hide resolved
tests/test_api_types.py Outdated Show resolved Hide resolved
Add tests for two missing functions
Change import location
@bashtage
Copy link
Contributor Author

bashtage commented Sep 6, 2022

pandas-dev/pandas#48414

Copy link
Collaborator

@Dr-Irv Dr-Irv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @bashtage

@Dr-Irv Dr-Irv merged commit afb7c76 into pandas-dev:main Sep 6, 2022
@bashtage bashtage deleted the api-is branch September 15, 2022 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants