Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XSS Vulnerability in Javascript: string #709

Open
pzyc0k opened this issue Jul 22, 2019 · 2 comments
Open

XSS Vulnerability in Javascript: string #709

pzyc0k opened this issue Jul 22, 2019 · 2 comments

Comments

@pzyc0k
Copy link

pzyc0k commented Jul 22, 2019

Test Environment
Google Chrome - Version 75.0.3770.142 (Official Build) (64-bit)

Description
A malicious actor may insert and finally execute malicious Javascript code.

Steps to reproduce

  1. Go to https://pandao.github.io/editor.md/en.html or any open editor.md apps
  2. In the edit mode, input the following malicious code snippet:
[xss poc](Javascript:alert("pzyc0 poc xss with cookie: " + document.cookie))

Impact
If an attacker can control a script that is executed in the victim's browser, then they can typically fully compromise that user.

Expected Results
No malicious Javascript code should be executed

Remediation
In general, it is highly recommended to implement input validation, output sanitization and escaping.

Proof-of-Concept
poc_xss

@pzyc0k pzyc0k changed the title XSS Vulnerability in <href> label XSS Vulnerability in Javas&#99;ript: string Aug 2, 2019
@Xh4H
Copy link

Xh4H commented Dec 2, 2019

Why are you using &#99; if a plain Javascript:alert works?

@alromh87
Copy link

alromh87 commented Sep 9, 2020

Can you try against this version please, also be sure the have the iframe filter enabled:
https://github.com/418sec/editor.md

alromh87 added a commit to alromh87/editor.md that referenced this issue Sep 10, 2020
fixes #pandao#612
fixes #pandao#662
fixes #pandao#697
fixes #pandao#700
fixes #pandao#701
fixes #pandao#709
fixes #pandao#715
fixes #pandao#764
fixes #pandao#816

### Probably:
fixes #pandao#307
fixes #pandao#560
alromh87 added a commit to alromh87/editor.md that referenced this issue Sep 10, 2020
fixes #pandao#612
fixes #pandao#662
fixes #pandao#697
fixes #pandao#700
fixes #pandao#701
fixes #pandao#709
fixes #pandao#715
fixes #pandao#764
fixes #pandao#816

fixes #pandao#307
fixes #pandao#560
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants