Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

<Tweak> return early like V4Router.sol #8

Closed
ChefMist opened this issue Sep 7, 2024 · 0 comments · Fixed by #13
Closed

<Tweak> return early like V4Router.sol #8

ChefMist opened this issue Sep 7, 2024 · 0 comments · Fixed by #13

Comments

@ChefMist
Copy link
Collaborator

ChefMist commented Sep 7, 2024

ref: pancakeswap/pancake-v4-periphery@4754d97
@ChefMist ChefMist mentioned this issue Sep 7, 2024
Merged
ChefMist added a commit that referenced this issue Sep 12, 2024
@ChefMist
feat: #8 return early
dfa33a6
@ChefMist ChefMist mentioned this issue Sep 12, 2024
Merged
ChefMist added a commit that referenced this issue Sep 13, 2024
@ChefMist
feat: #8 return early (gas optimization) (#13)
e655693 
* feat: updated pancake-v4-periphery

* feat: update test cases based on latest v4-periphery

* feat: updated v4-periphery

* feat: update code based on latest commit

* chore: clean up commented code

* feat: #8 return early

* feat: add missing early return for 1 command

* chore: forge-test after merge

* feat: prevent permit2.permit frontrun (#14)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: #8 return early (gas optimization) pancakeswap/pancake-v4-universal-router
1 participant
@ChefMist