feat: add offchain clPosition descriptor #33
Conversation
| /// @inheritdoc ICLPositionDescriptor | ||
| function tokenURI(ICLPositionManager, uint256 tokenId) external view override returns (string memory) { | ||
| return bytes(_baseTokenURI).length > 0 ? string(abi.encodePacked(_baseTokenURI, tokenId.toString())) : ""; | ||
| } |
There was a problem hiding this comment.
if we do not want to do it with upgradable.
Can we add a public variable , tokenURIContract
address tokenURIContract;
if this tokenURIContract was set , not address(0) , we will read from this contract.
if it is address(0) , we will return current value.
Just a suggestion , in case we regret in the future.
|
|
||
| /** | ||
| * forge script --sig 'run(uint256)' script/01_DeployCLPositionDescriptor.s.sol:DeployCLPositionDescriptorOffChainScript <baseTokenURI> -vvv \ | ||
| * --rpc-url $RPC_URL \ |
There was a problem hiding this comment.
should be --sig 'run(string)' ?
There was a problem hiding this comment.
script/01_DeployCLPositionDescriptor.s.sol -> script/01_DeployCLPositionDescriptorOffchain.s.sol
There was a problem hiding this comment.
would prefer if we can read from the config though, so future devs knows that params and can deploy this easily
| @@ -82,6 +92,10 @@ contract CLPositionManager is | |||
| _; | |||
| } | |||
|
|
|||
| function tokenURI(uint256 tokenId) public view override returns (string memory) { | |||
| return ICLPositionDescriptor(tokenDescriptor).tokenURI(this, tokenId); | |||
| } | |||
There was a problem hiding this comment.
tokenDescriptor is already ICLPositionDescriptor type
| } | ||
|
|
||
| function setTokenURIContract(ICLPositionDescriptor newTokenURIContract) external onlyOwner { | ||
| tokenURIContract = newTokenURIContract; |
There was a problem hiding this comment.
(optional) others might suggest an event emitted for such cases
The PR support tokenURI() interface for CLPositionMananger. Key points:
baseTokenURIsetter (onlyOwner) in case any future update on uri rule