refactor: repalce positionConfig with positionInfo #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chefburger
force-pushed
the
refactor/replace-positionConfig-with-positionInfo
branch
from
1627b8d
to
8da8744
Compare
chefburger
force-pushed
the
refactor/replace-positionConfig-with-positionInfo
branch
from
8da8744
to
34a1b4f
Compare
ChefMist
reviewed
Sep 12, 2024
| } | ||
|
|
||
| /// @inheritdoc ICLPositionManager | ||
| function getPositionConfigId(uint256 tokenId) external view returns (bytes32) { | ||
| return positionConfigs[tokenId].getConfigId(); | ||
| function positions(uint256 tokenId) |
There was a problem hiding this comment.
i wonder if it might be possible to also include hasSubscriber in this positions(uint256 tokenId) -- all the other related fields about position seems to be here
in the end maybe FE will just call positions(uint256 tokenId) most of the time
ChefMist
reviewed
Sep 12, 2024
src/pool-cl/CLPositionManager.sol
Outdated
Comment on lines
246
to
248
| if (address(poolKeys[poolId].poolManager) == address(0)) { | ||
| poolKeys[poolId] = poolKey; | ||
| } |
There was a problem hiding this comment.
this seems to be cheaper in gas
// if parameter (hook permission and tickSpacing) is bytes(0), it means the pool is not initialized yet
if (poolKeys[poolId].parameters == bytes32(0)) {
poolKeys[poolId] = poolKey;
}
There was a problem hiding this comment.
verified on my side as well 😂 interesting
ChefMist
approved these changes
Sep 12, 2024
chefburger
deleted the
refactor/replace-positionConfig-with-positionInfo
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.