[Gas optimization] Suggestion from Ottersec #180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ChefSnoopy
reviewed
Oct 8, 2024
| @@ -12,7 +12,7 @@ pragma solidity ^0.8.20; | |||
| * simply including this module, only once the modifiers are put in place. | |||
| */ | |||
| abstract contract Pausable { | |||
| bool private _paused; | |||
| uint256 private _paused; | |||
There was a problem hiding this comment.
if so , should we remove the comments above ?
copy from ......
chefburger
reviewed
Oct 8, 2024
src/pool-cl/libraries/CLPosition.sol
Outdated
| mstore(add(fmp, 0x40), 0) // fmp+0x40 held salt | ||
| mstore(add(fmp, 0x20), 0) // fmp+0x20 held tickLower, tickUpper, salt | ||
| mstore(fmp, 0) // fmp held owner | ||
| mstore(0x0, or(shl(160, and(0xFFFFFF, tickUpper)), or(shl(184, tickLower), owner))) // tickLower at [0x06, 0x09), tickUpper at [0x09,0x0c), owner at [0x0c, 0x20) |
There was a problem hiding this comment.
i guess we might need to clear upper bits for owner as well i.e.and(0xFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFF, owner) since the or operation for owner is executed last
chefburger
reviewed
Oct 8, 2024
| mstore(add(fmp, 0x40), 0) // fmp+0x40 held salt | ||
| mstore(add(fmp, 0x20), 0) // fmp+0x20 held binId, salt | ||
| mstore(fmp, 0) // fmp held owner | ||
| mstore(0x0, or(shl(160, binId), owner)) // binId at [0x09,0x0c), owner at [0x0c, 0x20) |
There was a problem hiding this comment.
same as above, we might need to clear upper bits for owner
ChefSnoopy
previously approved these changes
Oct 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the gas feedback optimization from OtterSec