-
Notifications
You must be signed in to change notification settings - Fork 750
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tooltip improvements #91
Merged
hachiojidev
merged 8 commits into
pancakeswap:master
from
Chef-Cheems:fix/tooltip-improvements
May 3, 2021
+179
−95
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
6cd8c4e
fix: Use object as a prop for useTooltip
Chef-Cheems bfd899a
fix: Use inverted theme in tooltips
Chef-Cheems aefeb8b
feat: Add hasTooltip propr to text
Chef-Cheems 5855c55
fix: Fix delay issues on mobile
Chef-Cheems f20862f
fix: Prettier fix
Chef-Cheems b4c73ee
fix: Timeout types
Chef-Cheems 33f7801
fix: Specifically use browser setTimeout
Chef-Cheems 2fbe2a5
fix: Define TooltipText as a separate component
Chef-Cheems File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,9 @@ | ||
import styled from "styled-components"; | ||
import Text from "./Text"; | ||
|
||
const TooltipText = styled(Text)` | ||
text-decoration: ${({ theme }) => `underline dotted ${theme.colors.textSubtle}`}; | ||
text-underline-offset: 0.1em; | ||
`; | ||
|
||
export default TooltipText; | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,2 +1,3 @@ | ||
export { default as Text } from "./Text"; | ||
export { default as TooltipText } from "./TooltipText"; | ||
export type { TextProps } from "./types"; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,7 +1,17 @@ | ||
import { Placement, Padding } from "@popperjs/core"; | ||
|
||
export interface TooltipRefs { | ||
targetRef: React.Dispatch<React.SetStateAction<HTMLElement | null>>; | ||
tooltip: React.ReactNode; | ||
tooltipVisible: boolean; | ||
} | ||
|
||
export interface TooltipOptions { | ||
placement?: Placement; | ||
trigger?: TriggerType; | ||
arrowPadding?: Padding; | ||
tooltipPadding?: Padding; | ||
tooltipOffset?: [number, number]; | ||
} | ||
|
||
export type TriggerType = "click" | "hover" | "focus"; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is exactly what I was thinking...but exported from the Tooltip. No worries, we can think about alternative solutions later.